COMPAT: Categorical Subclassing #13827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
the
Compat
Current coverage is 85.28% (diff: 94.73%)@@ master #13827 diff @@
==========================================
Files 139 139
Lines 50057 50062 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42692 42695 +3
- Misses 7365 7367 +2
Partials 0 0
|
|
The changes in this PR are fine, but I'm not sure it's a good idea to subclassing Categorical in the API, though I would guess nothing major is likely to change before v2.0. |
|
It may better to discuss in #8640, I' m thinking the following stricture:
I don't think we have to wait for 2.0 as long as it does't break existing user's code, but it also should be discussed separatelly (in ML). |
| @@ -330,9 +330,9 @@ def __init__(self, values, categories=None, ordered=False, | |||
|
|
|||
| def copy(self): | |||
| """ Copy constructor. """ | |||
| return Categorical(values=self._codes.copy(), | |||
There was a problem hiding this comment.
maybe make a _constructor as that is the patter we are using for other classes
sinhrks
force-pushed
the
categorical_subclass
branch
2 times, most recently
from
1a08cf9 to
55a195b
Compare
|
Updated to use |
sinhrks
force-pushed
the
categorical_subclass
branch
from
55a195b to
13c456c
Compare
|
ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffIt allows to subclass
Categoricalrelated to #8640. Shoud it use_simple_newor_constructor?