BUG: Respect the dtype parameter for empty CSV #14717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Bug
Dtype Conversions
jreback
reviewed
Nov 22, 2016
|
|
||
| if index_col is None or index_col is False: | ||
| index = Index([]) | ||
| else: | ||
| index = [np.empty(0, dtype=dtype.get(index_name, np.object)) | ||
| index = [np.empty(0, dtype=dtype[index_name]) |
There was a problem hiding this comment.
this will break on category
jreback
reviewed
Nov 22, 2016
| for index_name in index_names] | ||
| index = MultiIndex.from_arrays(index, names=index_names) | ||
| index_col.sort() | ||
| for i, n in enumerate(index_col): | ||
| columns.pop(n - i) | ||
|
|
||
| col_dict = dict((col_name, | ||
| np.empty(0, dtype=dtype.get(col_name, np.object))) | ||
| np.empty(0, dtype=dtype[col_name])) |
jreback
requested changes
Nov 22, 2016
| dtype={'a': np.float64}) | ||
| tm.assert_frame_equal(result, expected) | ||
|
|
||
| expected = pd.DataFrame(columns=['a', 'b']) |
There was a problem hiding this comment.
for completeness, can you tests with timedelta/datetime/category as well.
gfyoung
force-pushed
the
csv-empty-dtype
branch
from
30ac610 to
f87a976
Compare
Current coverage is 85.21% (diff: 100%)@@ master #14717 diff @@
==========================================
Files 143 143
Lines 50796 50800 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43285 43289 +4
Misses 7511 7511
Partials 0 0
|
gfyoung
force-pushed
the
csv-empty-dtype
branch
from
f87a976 to
cee4d6a
Compare
jorisvandenbossche
approved these changes
Nov 23, 2016
jreback
approved these changes
Nov 23, 2016
|
lgtm. I restarted appveyor. If that doesn't pass, then pls have a look @gfyoung |
|
I would be fine with this for 0.19.2 a well. @jorisvandenbossche up to you. |
4 tasks
|
@jreback , @jorisvandenbossche : Everything passing. Ready to merge if there are no other concerns. |
|
@gfyoung Thanks. Moved to 0.19.2 |
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Nov 26, 2016
Issue pandas-dev#14606 was fixed by PR pandas-dev#14717, adding one more specific test to confirm this
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Nov 26, 2016
Issue pandas-dev#14606 was fixed by PR pandas-dev#14717, adding one more specific test to confirm this
jorisvandenbossche
added a commit
that referenced
this pull request
Dec 10, 2016
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Dec 14, 2016
…y CSV (pandas-dev#14717) (cherry picked from commit 75b606a)
ischurov
pushed a commit
to ischurov/pandas
that referenced
this pull request
Dec 19, 2016
…andas-dev#14752) Issue pandas-dev#14606 was fixed by PR pandas-dev#14717, adding one more specific test to confirm this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory. Closes #14712.
Should be merged in before #14295 because the bug could also exist for the Python parser.