BUG: MultiIndex truncated for some non-list arguments #14806
Conversation
groutr
changed the title
| string_and_binary_types = string_types + (binary_type,) | ||
|
|
||
|
|
||
| class ABC(object): |
There was a problem hiding this comment.
revert all this. way out of scope for this issue.
| @@ -10,7 +10,7 @@ | |||
| import pandas.index as _index | |||
| from pandas.lib import Timestamp | |||
|
|
|||
| from pandas.compat import range, zip, lrange, lzip, map | |||
There was a problem hiding this comment.
just import directly from itertools
There was a problem hiding this comment.
zip_longest changed names between Python 2/3 (it was izip_longest in Python 2)
| MultiIndex.from_product : Make a MultiIndex from cartesian product | ||
| of iterables | ||
| """ | ||
| try: | ||
| arrays = list(arrays) |
| else: | ||
| arrays = lzip(*tuples) | ||
|
|
||
| arrays = zip_longest(*tuples) |
There was a problem hiding this comment.
revert all except for this change here
|
pls add tests first. just make the simple change and get it to work. then you can do follows to restructure if necessary / more clear. There are a lot of things going going on here (IOW lots of routines hit this), and lots of variations of accepted, so need to be quite careful (and more so about performance). |
|
Thank you. I guess I got carried away. I'll do a fresh start and open a new PR. |
closes #14794.
WIP. Discussion/suggestions welcome.