[WIP]: Add quantile shortcut #15032
Closed
[WIP]: Add quantile shortcut #15032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests! |
jreback
requested changes
Jan 1, 2017
Current coverage is 84.76% (diff: 33.33%)@@ master #15032 diff @@
==========================================
Files 145 145
Lines 51131 51138 +7
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43346 43347 +1
- Misses 7785 7791 +6
Partials 0 0
|
jreback
reviewed
Jan 2, 2017
| @@ -1026,6 +1026,22 @@ def mean(self, *args, **kwargs): | |||
|
|
|||
| @Substitution(name='groupby') | |||
| @Appender(_doc_template) | |||
| def quantile(self, *args, **kwargs): | |||
There was a problem hiding this comment.
not sure what you are doing here, this doesn't affect .resample.
but more importantly w/o tests it is impossible to tell.
|
can you rebase / update |
|
if you'd like to add tests and finish this up, pls ping. |
|
Ping @srinivasreddy. Would have used this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff