Skip to content

Bug:DataFrame index & column returned by corr & cov are the same (#14617) #15528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Feb 28, 2017

This picks up PR #14667. Ensures that the column and index returned by cov() and corr() are not the same object.

@codecov-io
Copy link

Codecov Report

Merging #15528 into master will decrease coverage by -0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15528      +/-   ##
==========================================
- Coverage    91.1%   91.08%   -0.03%     
==========================================
  Files         136      136              
  Lines       49102    49104       +2     
==========================================
- Hits        44736    44725      -11     
- Misses       4366     4379      +13
Impacted Files Coverage Δ
pandas/core/frame.py 97.74% <100%> (-0.1%)
pandas/io/gbq.py 40% <0%> (-46.67%)
pandas/util/decorators.py 68.26% <0%> (-0.97%)
pandas/tools/merge.py 91.78% <0%> (-0.35%)
pandas/util/testing.py 81.87% <0%> (-0.19%)
pandas/core/common.py 91.36% <0%> (+0.33%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23889d3...5a46f0a. Read the comment docs.

@jorisvandenbossche jorisvandenbossche changed the title Bug:DataFrame index & column returned by corr & cov are the same (#14… Bug:DataFrame index & column returned by corr & cov are the same (#14617) Feb 28, 2017
@jorisvandenbossche jorisvandenbossche added Bug Numeric Operations Arithmetic, Comparison, and Logical operations labels Feb 28, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Feb 28, 2017
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jreback jreback closed this in d0a281f Feb 28, 2017
@jreback
Copy link
Contributor

jreback commented Feb 28, 2017

very nice @mroeschke

keep em coming!

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
…ndas-dev#14617)

closes pandas-dev#14617

Author: Matt Roeschke <emailformattr@gmail.com>

Closes pandas-dev#15528 from mroeschke/fix_14617 and squashes the following commits:

5a46f0a [Matt Roeschke] Bug:DataFrame index & column returned by corr & cov are the same (pandas-dev#14617)
@mroeschke mroeschke deleted the fix_14617 branch December 20, 2017 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Columns and Index share the same numpy object underneath when pd.DataFrame.cov is used
4 participants