Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise What's New for inferring compression from non-string paths #17338

Merged
merged 5 commits into from
Sep 24, 2017
Merged

Revise What's New for inferring compression from non-string paths #17338

merged 5 commits into from
Sep 24, 2017

Conversation

dhimmel
Copy link
Contributor

@dhimmel dhimmel commented Aug 25, 2017

This pull request improves the What's New message corresponding to #17206, which updated io.common._infer_compression to infer compression from non-string paths.

Refs #17262
Refs #17206 (comment)

@codecov
Copy link

codecov bot commented Aug 25, 2017

Codecov Report

Merging #17338 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17338      +/-   ##
==========================================
- Coverage   91.01%   90.99%   -0.02%     
==========================================
  Files         162      162              
  Lines       49567    49567              
==========================================
- Hits        45113    45104       -9     
- Misses       4454     4463       +9
Flag Coverage Δ
#multiple 88.77% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f92eb...14fb91a. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 25, 2017

Codecov Report

Merging #17338 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17338      +/-   ##
==========================================
- Coverage   91.01%   90.99%   -0.02%     
==========================================
  Files         162      162              
  Lines       49567    49567              
==========================================
- Hits        45113    45104       -9     
- Misses       4454     4463       +9
Flag Coverage Δ
#multiple 88.77% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f92eb...14fb91a. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 25, 2017 •
edited
Loading

Codecov Report

Merging #17338 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17338      +/-   ##
==========================================
- Coverage   91.26%   91.02%   -0.25%     
==========================================
  Files         163      162       -1     
  Lines       49776    49567     -209     
==========================================
- Hits        45426    45116     -310     
- Misses       4350     4451     +101
Flag Coverage Δ
#multiple 88.8% <ø> (-0.24%) ⬇️
#single 40.24% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/s3.py 0% <0%> (-85%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/tools/datetimes.py 67.03% <0%> (-18.18%) ⬇️
pandas/util/_decorators.py 66% <0%> (-12%) ⬇️
pandas/core/dtypes/missing.py 87.19% <0%> (-3.26%) ⬇️
pandas/core/reshape/pivot.py 95.36% <0%> (-1%) ⬇️
pandas/core/indexes/interval.py 92.61% <0%> (-0.96%) ⬇️
pandas/io/common.py 67.79% <0%> (-0.85%) ⬇️
pandas/core/indexes/range.py 92.18% <0%> (-0.65%) ⬇️
pandas/core/indexes/timedeltas.py 90.58% <0%> (-0.61%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43aba8...def03f5. Read the comment docs.

jorisvandenbossche
jorisvandenbossche reviewed Aug 27, 2017
View reviewed changes
doc/source/whatsnew/v0.21.0.txt Outdated
@@ -126,7 +126,7 @@ Other Enhancements
- :func:`date_range` now accepts 'Y' in addition to 'A' as an alias for end of year (:issue:`9313`)
- Integration with `Apache Parquet <https://parquet.apache.org/>`__, including a new top-level :func:`read_parquet` and :func:`DataFrame.to_parquet` method, see :ref:`here <io.parquet>`.
- :func:`DataFrame.add_prefix` and :func:`DataFrame.add_suffix` now accept strings containing the '%' character. (:issue:`17151`)
- `read_*` methods can now infer compression from non-string paths, such as ``pathlib.Path`` objects (:issue:`17206`).
- Certain read/write methods can now infer compression from non-string paths, such as ``pathlib.Path`` objects (:issue:`17206`). Only io methods that rely on ``io.common._infer_compression`` are affected, which at this time is ``read_csv``, ``read_table``, ``read_pickle``, and ``write_pickle`` (:issue:`17262`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should mention the private io.common._infer_compression in the whatsnew notes, I would just list the improved functions. (also write_pickle is not a public one -> to_pickle)

@jorisvandenbossche jorisvandenbossche added this to the 0.21.0 milestone Aug 27, 2017
jreback
jreback reviewed Sep 23, 2017
View reviewed changes
doc/source/whatsnew/v0.21.0.txt Outdated
@@ -126,7 +126,7 @@ Other Enhancements
- :func:`date_range` now accepts 'Y' in addition to 'A' as an alias for end of year (:issue:`9313`)
- Integration with `Apache Parquet <https://parquet.apache.org/>`__, including a new top-level :func:`read_parquet` and :func:`DataFrame.to_parquet` method, see :ref:`here <io.parquet>`.
- :func:`DataFrame.add_prefix` and :func:`DataFrame.add_suffix` now accept strings containing the '%' character. (:issue:`17151`)
- `read_*` methods can now infer compression from non-string paths, such as ``pathlib.Path`` objects (:issue:`17206`).
- Read/write methods that infer compression (``read_csv``, ``read_table``, ``read_pickle``, and ``to_pickle``) can now infer from non-string paths, such as ``pathlib.Path`` objects (:issue:`17206`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use :func:`read_csv` and so on.

@jreback
Copy link
Contributor

jreback commented Sep 23, 2017

minor comment. pls rebase. ping on green.

@jorisvandenbossche jorisvandenbossche merged commit c95eb38 into pandas-dev:master Sep 24, 2017
@jorisvandenbossche
Copy link
Member

Updated and merged. Thanks @dhimmel !

alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
@dhimmel @alanbato
DOC: revise What's New for inferring compression from non-string paths (
ccca9b7 
pandas-dev#17338)

Refs pandas-dev#17262
Refs pandas-dev#17206 (comment)
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@dhimmel @No-Stream
DOC: revise What's New for inferring compression from non-string paths (
5f3f8d5 
pandas-dev#17338)

Refs pandas-dev#17262
Refs pandas-dev#17206 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dhimmel @jreback @jorisvandenbossche