Use cache_readonly attrs to minimize attrs set in __init__ #17450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step towards making dateOffset immutable, is an approach suggested by @shoyer
jreback
reviewed
Sep 7, 2017
pandas/tseries/offsets.py
Outdated
| @@ -2324,12 +2320,28 @@ def __init__(self, n=1, normalize=False, **kwds): | |||
| raise ValueError('{variation} is not a valid variation' | |||
| .format(variation=self.variation)) | |||
|
|
|||
| @cache_readonly | |||
| def _rd_forward(self): | |||
There was a problem hiding this comment.
I would spell things out. (_relativedelta_forward)
Codecov Report
@@ Coverage Diff @@
## master #17450 +/- ##
==========================================
- Coverage 91.15% 91.13% -0.03%
==========================================
Files 163 163
Lines 49587 49593 +6
==========================================
- Hits 45203 45197 -6
- Misses 4384 4396 +12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17450 +/- ##
==========================================
- Coverage 91.15% 91.13% -0.03%
==========================================
Files 163 163
Lines 49587 49597 +10
==========================================
- Hits 45203 45201 -2
- Misses 4384 4396 +12
Continue to review full report at Codecov.
|
4 tasks
gfyoung
added
Clean
Internals
jreback
added
Frequency
|
this is fine. thanks. |
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to break the fixes to
offsetsinto small pieces. Recall the goal is to makeDateOffsetimmutable so as to fix the very slow__eq__calls that get made byPeriod.__eq__and thePeriodIndexconstructor.As a step towards immutability, this PR is trying to reduce the number of attributes set in
__init__, as suggested by @shoyer a while back.In two places the
__init__methods are identical to those of the parent class, so are removed.