DEPR: Add warning for True for dropna of SeriesGroupBy.nth #17493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @tnir! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 12, 2017 at 08:38 Hours UTC |
tnir
force-pushed
the
groupby-nth-dropna-deprecation
branch
from
c5058c2 to
a621b7c
Compare
gfyoung
added
Deprecate
tnir
force-pushed
the
groupby-nth-dropna-deprecation
branch
from
a621b7c to
72a8fda
Compare
Codecov Report
@@ Coverage Diff @@
## master #17493 +/- ##
==========================================
- Coverage 91.15% 91.13% -0.02%
==========================================
Files 163 163
Lines 49534 49537 +3
==========================================
- Hits 45153 45147 -6
- Misses 4381 4390 +9
Continue to review full report at Codecov.
|
tnir
changed the title
tnir
force-pushed
the
groupby-nth-dropna-deprecation
branch
from
72a8fda to
3e344b8
Compare
|
thanks @tnir |
1 task
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Sep 23, 2017
dropna=True is deprecated, see pandas-dev#17493
jreback
pushed a commit
that referenced
this pull request
Sep 23, 2017
dropna=True is deprecated, see #17493
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
dropna=True is deprecated, see pandas-dev#17493
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
dropna=True is deprecated, see pandas-dev#17493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff