Skip to content

COMPAT: Suppress .take() warning for numpy < 1.12 #17764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 3, 2017

Follow-up to #17352.

@gfyoung gfyoung added the Compat pandas objects compatability with Numpy or Python functions label Oct 3, 2017
@gfyoung gfyoung added this to the 0.21.0 milestone Oct 3, 2017
@jreback
Copy link
Contributor

jreback commented Oct 3, 2017

lgtm. merge on green.

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #17764 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17764      +/-   ##
==========================================
- Coverage   91.23%   91.21%   -0.02%     
==========================================
  Files         163      163              
  Lines       49869    49869              
==========================================
- Hits        45499    45490       -9     
- Misses       4370     4379       +9
Flag Coverage Δ
#multiple 89.01% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff1241...4f4d1ef. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #17764 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17764      +/-   ##
==========================================
- Coverage   91.23%   91.21%   -0.02%     
==========================================
  Files         163      163              
  Lines       49869    49869              
==========================================
- Hits        45499    45490       -9     
- Misses       4370     4379       +9
Flag Coverage Δ
#multiple 89.01% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.73% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff1241...4f4d1ef. Read the comment docs.

@jreback jreback merged commit 9ac7c51 into pandas-dev:master Oct 3, 2017
@jreback
Copy link
Contributor

jreback commented Oct 3, 2017

thanks @gfyoung

@gfyoung gfyoung deleted the take-convert-depr-followup branch October 4, 2017 01:52
ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants