Skip to content

CLN: Drop the skip_footer parameter in read_csv #18724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions doc/source/io.rst
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,6 @@ skiprows : list-like or integer, default ``None``

skipfooter : int, default ``0``
Number of lines at bottom of file to skip (unsupported with engine='c').
skip_footer : int, default ``0``
.. deprecated:: 0.19.0

Use the ``skipfooter`` parameter instead, as they are identical

nrows : int, default ``None``
Number of rows of file to read. Useful for reading pieces of large files.
Expand Down
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.22.0.txt
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ Removal of prior version deprecations/changes
- The ``freq`` and ``how`` parameters have been removed from the ``rolling``/``expanding``/``ewm`` methods of DataFrame
and Series (deprecated since v0.18). Instead, resample before calling the methods. (:issue:18601 & :issue:18668)
- ``DatetimeIndex.to_datetime``, ``Timestamp.to_datetime``, ``PeriodIndex.to_datetime``, and ``Index.to_datetime`` have been removed (:issue:`8254`, :issue:`14096`, :issue:`14113`)
- :func:`read_csv` has dropped the ``skip_footer`` parameter (:issue:`13386`)

.. _whatsnew_0220.performance:

Expand Down
13 changes: 1 addition & 12 deletions pandas/io/parsers.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,6 @@
An example of a valid callable argument would be ``lambda x: x in [0, 2]``.
skipfooter : int, default 0
Number of lines at bottom of file to skip (Unsupported with engine='c')
skip_footer : int, default 0
.. deprecated:: 0.19.0
Use the `skipfooter` parameter instead, as they are identical
nrows : int, default None
Number of rows of file to read. Useful for reading pieces of large files
na_values : scalar, str, list-like, or dict, default None
Expand Down Expand Up @@ -613,7 +610,6 @@ def parser_f(filepath_or_buffer,
warn_bad_lines=True,

skipfooter=0,
skip_footer=0, # deprecated

# Internal
doublequote=True,
Expand Down Expand Up @@ -641,13 +637,6 @@ def parser_f(filepath_or_buffer,
engine = 'c'
engine_specified = False

if skip_footer != 0:
warnings.warn("The 'skip_footer' argument has "
"been deprecated and will be removed "
"in a future version. Please use the "
"'skipfooter' argument instead.",
FutureWarning, stacklevel=2)

kwds = dict(delimiter=delimiter,
engine=engine,
dialect=dialect,
Expand Down Expand Up @@ -682,7 +671,7 @@ def parser_f(filepath_or_buffer,
nrows=nrows,
iterator=iterator,
chunksize=chunksize,
skipfooter=skipfooter or skip_footer,
skipfooter=skipfooter,
converters=converters,
dtype=dtype,
usecols=usecols,
Expand Down
7 changes: 1 addition & 6 deletions pandas/tests/io/parser/test_unsupported.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,16 +137,11 @@ class TestDeprecatedFeatures(object):
{"use_unsigned": True},
{"use_unsigned": False},
{"tupleize_cols": True},
{"tupleize_cols": False},
{"skip_footer": 1}])
{"tupleize_cols": False}])
def test_deprecated_args(self, engine, kwargs):
data = "1,2,3"
arg, _ = list(kwargs.items())[0]

if engine == "c" and arg == "skip_footer":
# unsupported --> exception is raised
return

if engine == "python" and arg == "buffer_lines":
# unsupported --> exception is raised
return
Expand Down