ENH: Let Categorical.rename_categories take a callable #18862
Conversation
topper-123
force-pushed
the
rename_categories_callable
branch
3 times, most recently
from
6ab28d6 to
fa0ed70
Compare
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -139,6 +139,7 @@ Other Enhancements | |||
| - :func:`read_excel()` has gained the ``nrows`` parameter (:issue:`16645`) | |||
| - :func:``DataFrame.to_json`` and ``Series.to_json`` now accept an ``index`` argument which allows the user to exclude the index from the JSON output (:issue:`17394`) | |||
| - ``IntervalIndex.to_tuples()`` has gained the ``na_tuple`` parameter to control whether NA is returned as a tuple of NA, or NA itself (:issue:`18756`) | |||
| - ``Categorical.rename_categories`` can how take a callable as its argument (:issue:`18862`) | |||
There was a problem hiding this comment.
use :func:`Categorical.rename_categories` here
There was a problem hiding this comment.
Also, we don't have Categorical in the API docs yet, so that won't work.
:meth:`Series.cat.rename_categories`
may work (though it applies to CategoricalIndex too).
There was a problem hiding this comment.
actually let's also test this for a CI and a Series.cat.rename_categories
There was a problem hiding this comment.
Not sure I understand this about CI. I assume that will be a seperate PR? else I'd appreciate guidance.
Do you mean test Series.cat.rename_categories? Isn't it a bit odd as that's a delegation from the Categorical namespace (not at the coding computer ATM, but that's how I understand it)?
There was a problem hiding this comment.
CI = CategoricalIndex, sure its separate but makes sense to do it here (it should just work). Series.cat....IS a delegation, but we do test things there as well (for example to make sure things are passed thru). See what we have for testing and add as appropriate (or indicate that we are not testing except for basic functionaility).
There was a problem hiding this comment.
Ok, I understood CI as Continuous Integration. Sure, I can take a look at adding a test for CategoricalIndex,
pandas/core/categorical.py
Outdated
| @@ -854,6 +854,10 @@ def rename_categories(self, new_categories, inplace=False): | |||
| are passed through and extra categories in the mapping are | |||
| ignored. *New in version 0.21.0*. | |||
|
|
|||
| * callable : a callable that is called on all items in the old | |||
| categories and whose return values comprise the new categories. | |||
| *New in version 0.22.0*. | |||
There was a problem hiding this comment.
and if you'd fix the prior one as well
pandas/tests/categorical/test_api.py
Outdated
| @@ -71,9 +71,14 @@ def test_rename_categories(self): | |||
|
|
|||
| exp_cat = Index(["a", "b", "c"]) | |||
| tm.assert_index_equal(cat.categories, exp_cat) | |||
| res = cat.rename_categories([1, 2, 3], inplace=True) | |||
|
|
|||
| # GH18862 | |||
topper-123
force-pushed
the
rename_categories_callable
branch
from
fa0ed70 to
f7c867e
Compare
|
Updated and all green. |
|
BTW, on Github, in the timeline this is added to the 0.22 milestone, but on the right side overview, it says milestone 0.23. Seems to be something strange going on? |
corrected a minor spelling error
|
thanks @topper-123 we are going to release 0.22 shortly with #18876 only, everything else gets moved to 0.23. |
git diff upstream/master -u -- "*.py" | flake8 --diffThis PR allows
Categorical.rename_categoriesto take a callable as its argument.This is useful for quickly changing the categories the same way for all categories, e.g.