Fixing 3.6 Escape Sequence Deprecations in tests/io/parser/usecols.py #18918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18918 +/- ##
==========================================
+ Coverage 91.65% 91.67% +0.02%
==========================================
Files 154 154
Lines 51368 51368
==========================================
+ Hits 47080 47092 +12
+ Misses 4288 4276 -12
Continue to review full report at Codecov.
|
|
you export this variable to your env, then run them. look on the 3.6 build to see in travis. |
jreback
added
the
Compat
|
thanks! |
|
FYI #18968 I fixed the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jreback brought up some warnings on 3.6 that should be fixed by making the regex an r'string'.
Tests pass, happy to fix all the other occurrences, would need to know how to generate these warnings on my local machine though, as running the same pytest command as CI doesn't seem to bring them up for me.