-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Continue porting period_helper to cython #19608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19608 +/- ##
==========================================
- Coverage 91.62% 91.61% -0.01%
==========================================
Files 150 150
Lines 48790 48790
==========================================
- Hits 44703 44701 -2
- Misses 4087 4089 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you run perf on periods
int64_t absdate, double abstime) nogil: | ||
""" | ||
Set the instance's value using the given date and time. | ||
Assumes GREGORIAN_CALENDAR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally add some full doc-strings on these which list the args and types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. Mind doing those in the next round to avoid clogging the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's fine
|
This moves functions to cython but retains their C names to make comparison easier. The next pass will get rid of the camelCase. A couple of redundant functions are left behind in period_helper, will be cleaned up in a follow-up.
The next hurdle is to get rid of all the adding and subtracting of ORD_OFFSET, WEEK_OFFSET, BDAY_OFFSET. (The period_helper code puts 0 at Jan 1 0001 instead of Jan 1 1970). This would be straightforward but I want to be careful about C division/mod conventions.