BUG: #19497 FIX. Add tupleize_cols option to internals._transform_index() #20526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20526 +/- ##
==========================================
- Coverage 91.84% 91.83% -0.01%
==========================================
Files 152 152
Lines 49259 49260 +1
==========================================
- Hits 45241 45240 -1
- Misses 4018 4020 +2
Continue to review full report at Codecov.
|
|
Ok, so from what I gather, the only change should be:
return Index(items, name=index.name, tupleize_cols=False)
(in internals._transform_index()). If that's agreed, I can make the change
on the other side of the weekend.
…On 30 March 2018 at 01:38, Tom Augspurger ***@***.***> wrote:
***@***.**** commented on this pull request.
I don't think that adding a new keyword to rename is the right level for
the fix. The original example in the issue is a bug. We should fix the bug,
not add a keyword to work around it.
I'd prefer a proper fix for #17246
<#17246> (Index(...,
dtype='object') is respected). Then to fix this bug, we'd pass through
self.index.dtype I think.
------------------------------
In pandas/core/frame.py
<#20526 (comment)>:
> @@ -3642,6 +3642,10 @@ def rename(self, *args, **kwargs):
level : int or level name, default None
In case of a MultiIndex, only rename labels in the specified
level.
+ tupleize_cols : boolean, default False
I'd prefer not to add a new keyword argument here. I don't think that
.rename should be able to change between Index and MultiIndex, so it
shouldn't be necessary.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20526 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADhP44mGQTUIL8gMcH0Cex8mZdWWtbyZks5tjPHJgaJpZM4S_0vU>
.
|
|
this PR is not likely to be accepted, esp as there are no tests. We are not going to be adding a specific argument to |
jreback
added
the
Indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffNOTE: for renaming, the keyword argument default is False, because as suggested here, this is unintuitive and unexepected. The keyword argument for the _transform_index() is True however, which is consistent with default pandas.Index() creation behaviour.