DOC: clarify default behavior for categories ordering #22081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22081 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 170 170
Lines 50688 50688
=======================================
Hits 46671 46671
Misses 4017 4017
Continue to review full report at Codecov.
|
|
lgtm. @TomAugspurger @jorisvandenbossche wording look ok? |
pandas/core/arrays/categorical.py
Outdated
| @@ -241,10 +241,14 @@ class Categorical(ExtensionArray, PandasObject): | |||
| categories will be replaced with NaN. | |||
| categories : Index-like (unique), optional | |||
| The unique categories for this categorical. If not given, the | |||
| categories are assumed to be the unique values of values. | |||
| categories are assumed to be the unique values of values (sorted, if | |||
There was a problem hiding this comment.
The second values should be in backticks.
toobaz
force-pushed
the
categorical_ordered_doc
branch
from
ea68572 to
ddb03e4
Compare
dberenbaum
pushed a commit
to dberenbaum/pandas
that referenced
this pull request
Aug 3, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffJust a doc clarification on default categories ordering, which can be pretty confusing when handling mixed dtypes (see also #22080 ).