Skip to content

Bug in date_range with semi-open interval and freq='B' #22095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2018

Conversation

louis-red
Copy link
Contributor

@louis-red louis-red commented Jul 28, 2018

First contribution so this PR is really light.
#6673 is resolved on master, but this PR adds some tests to confirm this behavior.

@jreback jreback changed the title Add some tests for #6673 Bug in date_range with semi-open interval and freq='B' Jul 28, 2018
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jul 28, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 28, 2018
@jreback
Copy link
Contributor

jreback commented Jul 28, 2018

can you rebase on master

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #22095 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22095      +/-   ##
==========================================
+ Coverage   92.06%   92.07%   +0.01%     
==========================================
  Files         170      170              
  Lines       50705    50688      -17     
==========================================
- Hits        46680    46671       -9     
+ Misses       4025     4017       -8
Flag Coverage Δ
#multiple 90.48% <ø> (+0.01%) ⬆️
#single 42.31% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/tools/datetimes.py 85.07% <0%> (-0.15%) ⬇️
pandas/io/sas/sas_xport.py 90.23% <0%> (-0.05%) ⬇️
pandas/io/formats/html.py 88.81% <0%> (-0.04%) ⬇️
pandas/core/indexing.py 93.79% <0%> (-0.03%) ⬇️
pandas/core/groupby/generic.py 86.79% <0%> (-0.02%) ⬇️
pandas/core/sparse/frame.py 94.78% <0%> (-0.02%) ⬇️
pandas/core/indexes/interval.py 94.11% <0%> (-0.02%) ⬇️
pandas/core/dtypes/dtypes.py 96.03% <0%> (-0.02%) ⬇️
pandas/core/internals/blocks.py 94.45% <0%> (-0.02%) ⬇️
pandas/core/nanops.py 95.12% <0%> (-0.01%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7a08b...5282b9f. Read the comment docs.

@jreback jreback merged commit 1dc7733 into pandas-dev:master Jul 31, 2018
@jreback
Copy link
Contributor

jreback commented Jul 31, 2018

thanks @louis-red FYI normally like to move things in a separate PR as the diff is more clear, but ok.

@louis-red
Copy link
Contributor Author

louis-red commented Aug 1, 2018

thanks @jreback, I'm not as familiar with git as I thought I was, and so got a bit puzzled when you asked me to rebase, was planning on doing so this week-end. Anyway thanks for the information, I keep learning !

dberenbaum pushed a commit to dberenbaum/pandas that referenced this pull request Aug 3, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants