CLN: Unused varables pt2 #22115
Merged
CLN: Unused varables pt2 #22115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jul 29, 2018
| @@ -305,7 +305,6 @@ def _hash_categories(categories, ordered=True): | |||
| # everything to a str first, which means we treat | |||
| # {'1', '2'} the same as {'1', 2} | |||
| # find a better solution | |||
| cat_array = np.array([hash(x) for x in categories]) | |||
There was a problem hiding this comment.
iirc this is a check that the categories can be hashed but i think we now check this on construction
|
All looks good besides a travis build that had connection issues. |
|
thanks! |
dberenbaum
pushed a commit
to dberenbaum/pandas
that referenced
this pull request
Aug 3, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffxref #21986
Remove more unused variables including ones that were marked in TODOs as unused.