Skip to content

DOC: Updating str_repeat docstring #22566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

DOC: Updating str_repeat docstring #22566

wants to merge 6 commits into from

Conversation

JesperDramsch
Copy link
Contributor

  • [ x] tests passed
  • [ x] passes git diff upstream/master -u -- "*.py" | flake8 --diff

Updated the Docstring with examples for str.repeat()

@pep8speaks
Copy link

pep8speaks commented Sep 1, 2018

Hello @JesperDramsch! Thanks for updating the PR.

Line 689:80: E501 line too long (86 > 79 characters)

Comment last updated on September 01, 2018 at 13:49 Hours UTC

@codecov
Copy link

codecov bot commented Sep 1, 2018

Codecov Report

Merging #22566 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22566   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50787    50787           
=======================================
  Hits        46745    46745           
  Misses       4042     4042
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 42.29% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/strings.py 98.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98fb53c...c2dbb94. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, very clear example. Added some comments about minor things.

@datapythonista datapythonista changed the title Cleaned up DocString for str_repeat and added examples DOC: Updating str_repeat docstring Sep 1, 2018
@datapythonista datapythonista added Docs Strings String extension data type and string data labels Sep 1, 2018
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example!

@JesperDramsch
Copy link
Contributor Author

I messed up. It goes on here: #22571

@jorisvandenbossche jorisvandenbossche added this to the No action milestone Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants