Fix blank line skipping in read_fwf, issue 22693

[xiejxie]

• closes read_fwf: skip_blank_lines does nothing #22693
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

Fixes the bug where blank lines are not skipped using read_fwf even when skip_blank_lines is set to true. Override default behaviour in FixedWidthFieldParser.

[pep8speaks]

Hello @xiejxie! Thanks for updating the PR.

• There are no PEP8 issues in the file pandas/io/parsers.py !

• There are no PEP8 issues in the file pandas/tests/io/parser/test_read_fwf.py !

Comment last updated on September 27, 2018 at 01:11 Hours UTC

[codecov]

Codecov Report

Merging #22849 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #22849      +/-   ##
==========================================
+ Coverage   92.19%   92.19%   +<.01%     
==========================================
  Files         169      169              
  Lines       50827    50835       +8     
==========================================
+ Hits        46860    46868       +8     
  Misses       3967     3967

Flag	Coverage Δ
#multiple	90.61% <100%> (ø)	⬆️
#single	42.36% <12.5%> (-0.01%)	⬇️

Impacted Files	Coverage Δ
pandas/io/parsers.py	95.62% <100%> (+0.02%)	⬆️
pandas/core/frame.py	97.2% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d115900...df95b71. Read the comment docs.

[jreback]

closing as stale. if you'd like to continue, pls ping.

[dvalters]

Hi @jreback, just wondering if we could pick this up and continue the work of @xiejxie here? Seems like we are on track towards a fix, just need a bit more iteration. (Also I think the current test might result in a false positive, as read_csv is also affected by the bug?)

[WillAyd]

@dwalters feel free to open a new PR

[TianyiPeng]

Hi @jreback, just wondering if we could pick this up and continue the work of @xiejxie here? Seems like we are on track towards a fix, just need a bit more iteration. (Also I think the current test might result in a false positive, as read_csv is also affected by the bug?)

@dvalters I would like to help but not sure how to do it. Any intuition on how to fix the read_csv bug?