CircleCI -> Azure #22992

TomAugspurger · 2018-10-04T14:50:58Z

cc @jreback @h-vetinari @jorisvandenbossche @WillAyd

The main thing we lose is redundancy on the sql tests. Those are down to just travis.

jschendel · 2018-10-04T15:32:18Z

doc/source/contributing.rst

 However, if you wish to run the test suite on a branch prior to submitting the pull request,
 then the continuous integration services need to be hooked to your GitHub repository. Instructions are here
-for `Travis-CI <http://about.travis-ci.org/docs/user/getting-started/>`__,
-`Appveyor <https://www.appveyor.com/docs/>`__ , and `CircleCI <https://circleci.com/>`__.
+for `Travis-CI <http://about.travis-ci.org/docs/user/getting-started/>`__.


small nitpick: http --> https

codecov · 2018-10-04T15:50:01Z

Codecov Report

Merging #22992 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22992   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         169      169           
  Lines       51259    51259           
=======================================
  Hits        47275    47275           
  Misses       3984     3984

Flag	Coverage Δ
#multiple	`90.66% <ø> (ø)`	⬆️
#single	`42.23% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd16b91...73c2413. Read the comment docs.

TomAugspurger · 2018-10-04T17:07:35Z

To summarize the changes:

Adds 3 new azure builds

2.7-compat
3.6-locale
3.6-local-slow

That puts us up to 6 azure builds.

The 3.5 build is dropped. I think that's fine for now.

The locale stuff isn't working yet. Still debugging.

TomAugspurger · 2018-10-04T19:05:08Z

OK I think the locale setting took effect. If you look at the summary in https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=656&view=ms.vss-test-web.test-result-details and search for a locale-related test, e.g. test_guess_datetime_format_with_locale_specific_formats, you'll see the skip message is Specific locale is set zh_CN.

I manually cancelled the travis build FYI, just to not overload it, it didn't fail on it's own.

edit: actually, restarting the travis build since I did have to change script-single and script-multi. For whatever reason the linux-based azure workers were having trouble publishing results from /tmp/*.xml. We got an insufficient privileges error, so maybe there's another xml file in there we can't touch. The solution was to just output the junitxml to our directory.

jreback · 2018-10-06T15:16:38Z

would be ok leaving the 1 circle ci test

jbrockmendel · 2018-10-13T16:55:25Z

ci/azure/linux.yml

+    - task: PublishTestResults@2
+      inputs:
+        testResultsFiles: 'test-data-*.xml'
+        testRunTitle: 'Linux'


GH wants a \n here

jbrockmendel · 2018-10-13T16:58:23Z

Needs rebase.

If circleCI isn't completely removed, it might be nice to collect the relevant scripts in ci/circleci/

TomAugspurger · 2018-10-25T02:31:12Z

Restored one circle job for the SQL redundancy.

I'd recommend that if circle is running behind, we feel free to ignore it for changes that aren't likely to affect the SQL behavior.

TomAugspurger · 2018-10-25T13:54:13Z

This is passing.

I'm not thrilled about having to maintain the circleci scripts, but it's probably worth it for the SQL redundancy.

jreback · 2018-10-26T02:01:50Z

@TomAugspurger I think i merged something in contributing.rst so rebase and let's merge on green.

TomAugspurger · 2018-10-26T12:07:28Z

Apparently, circleCI missed the web hook on my latest one. But it did pass in https://circleci.com/gh/pandas-dev/pandas/26751?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link, which only differed by the doc fixup, so merging.

…_pr4 * repo_org/master: TST: Fix test assertion (pandas-dev#23357) BUG: Handle Period in combine (pandas-dev#23350) REF: SparseArray imports (pandas-dev#23329) CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992) DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)

…_series_pr1 * repo_org/master: TST: Fix test assertion (pandas-dev#23357) BUG: Handle Period in combine (pandas-dev#23350) REF: SparseArray imports (pandas-dev#23329) CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992) DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)

…_pr2 * repo_org/master: DOC: Add docstring validations for "See Also" section (pandas-dev#23143) TST: Fix test assertion (pandas-dev#23357) BUG: Handle Period in combine (pandas-dev#23350) REF: SparseArray imports (pandas-dev#23329) CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992) DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051) Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341) TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304) API: Add sparse Acessor (pandas-dev#23183) PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)

…ndas * repo_org/master: (23 commits) DOC: Add docstring validations for "See Also" section (pandas-dev#23143) TST: Fix test assertion (pandas-dev#23357) BUG: Handle Period in combine (pandas-dev#23350) REF: SparseArray imports (pandas-dev#23329) CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992) DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051) Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341) TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304) API: Add sparse Acessor (pandas-dev#23183) PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235) fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302) BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317) TST: re-enable gbq tests (pandas-dev#23303) Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311) isort imports-io (pandas-dev#23332) DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279) REF: Make PeriodArray an ExtensionArray (pandas-dev#22862) DOC: Added Examples for Series max (pandas-dev#23298) API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644) BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291) ...

…xamples * repo_org/master: (83 commits) DOC: Add docstring validations for "See Also" section (pandas-dev#23143) TST: Fix test assertion (pandas-dev#23357) BUG: Handle Period in combine (pandas-dev#23350) REF: SparseArray imports (pandas-dev#23329) CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992) DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051) Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341) TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304) API: Add sparse Acessor (pandas-dev#23183) PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235) fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302) BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317) TST: re-enable gbq tests (pandas-dev#23303) Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311) isort imports-io (pandas-dev#23332) DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279) REF: Make PeriodArray an ExtensionArray (pandas-dev#22862) DOC: Added Examples for Series max (pandas-dev#23298) API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644) BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291) ...

TomAugspurger added 5 commits October 4, 2018 09:43

circle -> azure

0c25578

Update docs

799cbea

update locale setting

10b5988

all yaml

72ab6b6

Ignore error

80f374c

TomAugspurger mentioned this pull request Oct 4, 2018

CLN: Move some PI/DTI methods to EA subclasses, implement tests #22961

Merged

jschendel reviewed Oct 4, 2018

View reviewed changes

Try fix upload

31d2aea

locale-gen, results

8141ee4

TomAugspurger added 4 commits October 4, 2018 12:57

update test data location

a711e27

fixed quoting

c315e19

try sudo?

a74ce98

try without dpkg

0f7ce80

datapythonista added the CI Continuous Integration label Oct 4, 2018

jreback added this to the 0.24.0 milestone Oct 6, 2018

jbrockmendel reviewed Oct 13, 2018

View reviewed changes

TomAugspurger added 4 commits October 24, 2018 21:18

Merge remote-tracking branch 'upstream/master' into drop-circle

e4e46ed

Restore one

74f4dcc

36 -> 37

608ba04

move to circle

5fc0d96

Merge remote-tracking branch 'upstream/master' into drop-circle

73c2413

TomAugspurger merged commit 88a57c9 into pandas-dev:master Oct 26, 2018

TomAugspurger deleted the drop-circle branch October 26, 2018 12:07

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018

CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)

ef01d2c

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)

6085f5f

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)

0d25d67

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CircleCI -> Azure #22992

CircleCI -> Azure #22992

TomAugspurger commented Oct 4, 2018 •

edited by jreback

Loading

jschendel Oct 4, 2018

codecov bot commented Oct 4, 2018 •

edited

Loading

TomAugspurger commented Oct 4, 2018

TomAugspurger commented Oct 4, 2018 •

edited

Loading

jreback commented Oct 6, 2018

jbrockmendel Oct 13, 2018

jbrockmendel commented Oct 13, 2018

TomAugspurger commented Oct 25, 2018

TomAugspurger commented Oct 25, 2018

jreback commented Oct 26, 2018

TomAugspurger commented Oct 26, 2018

CircleCI -> Azure #22992

CircleCI -> Azure #22992

Conversation

TomAugspurger commented Oct 4, 2018 • edited by jreback Loading

jschendel Oct 4, 2018

Choose a reason for hiding this comment

codecov bot commented Oct 4, 2018 • edited Loading

Codecov Report

TomAugspurger commented Oct 4, 2018

TomAugspurger commented Oct 4, 2018 • edited Loading

jreback commented Oct 6, 2018

jbrockmendel Oct 13, 2018

Choose a reason for hiding this comment

jbrockmendel commented Oct 13, 2018

TomAugspurger commented Oct 25, 2018

TomAugspurger commented Oct 25, 2018

jreback commented Oct 26, 2018

TomAugspurger commented Oct 26, 2018

TomAugspurger commented Oct 4, 2018 •

edited by jreback

Loading

codecov bot commented Oct 4, 2018 •

edited

Loading

TomAugspurger commented Oct 4, 2018 •

edited

Loading