Skip to content

try pinning numpy dev #23178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2018
Merged

try pinning numpy dev #23178

merged 1 commit into from
Oct 16, 2018

Conversation

TomAugspurger
Copy link
Contributor

xref #22960

@TomAugspurger TomAugspurger added the CI Continuous Integration label Oct 16, 2018
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Oct 16, 2018
jreback
jreback reviewed Oct 16, 2018
View reviewed changes
ci/travis-37-numpydev.yaml
@@ -13,5 +13,5 @@ dependencies:
- "git+git://github.com/dateutil/dateutil.git"
- "-f https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com"
- "--pre"
- "numpy"
- "numpy<=1.16.0.dev0+20181015190246"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are just strings, so the < part won't work here, just pin = for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That grabbed NmPy commit 54985e3, so it seemed to have worked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://travis-ci.org/pandas-dev/pandas/jobs/442114100#L727

@TomAugspurger TomAugspurger mentioned this pull request Oct 16, 2018
Merged
4 tasks
@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Oct 16, 2018 •
edited
Loading

FYI, planning to merge once https://travis-ci.org/pandas-dev/pandas/jobs/442114100 passes, since this only affects that environment.

edit: and there is goes. Merging.

@TomAugspurger TomAugspurger merged commit 8af2bea into pandas-dev:master Oct 16, 2018
@TomAugspurger TomAugspurger deleted the pin-numpydev branch October 16, 2018 11:24
@codecov
Copy link

codecov bot commented Oct 16, 2018 •
edited
Loading

Codecov Report

Merging #23178 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23178   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         170      170           
  Lines       50963    50963           
=======================================
  Hits        46984    46984           
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa69d1...70c9163. Read the comment docs.

@h-vetinari
Copy link
Contributor

Something with pyarrow also started failing overnight (the azure Win36 job is failing for all recent builds: https://dev.azure.com/pandas-dev/pandas/_build - also happened for this PR, but for some reason the azure link is not visible in the results anymore; here it is): https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=1251&view=logs

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@TomAugspurger @tm9k1
try pinning numpy dev (pandas-dev#23178)
010e4a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAugspurger @h-vetinari @jreback