Skip to content

TST: xfail gbq & feather tests for now as version incompat #23281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Oct 22, 2018

@jreback jreback added Testing pandas testing functions or related to the test suite IO Data IO issues that don't fit into a more specific label IO Google labels Oct 22, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 22, 2018
@jreback
Copy link
Contributor Author

jreback commented Oct 22, 2018

cc @tswast is this a newer pandas-gbq?

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. I removed these methods in googleapis/python-bigquery-pandas#216 (I thought they were unused.) Since listing datasets while you are deleting them is flakey, I updated the pandas-gbq tests in that PR to use a fixture to create a random dataset and delete it when the test finishes.

@jreback
Copy link
Contributor Author

jreback commented Oct 22, 2018

ok that's fine. can you PR to pandas to fix this up?

@jreback jreback changed the title TST: xfail gbq & feather tests for new version incompat TST: xfail gbq & feather tests for now as version incompat Oct 22, 2018
@pep8speaks
Copy link

Hello @jreback! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4cac923). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #23281   +/-   ##
=========================================
  Coverage          ?   92.19%           
=========================================
  Files             ?      169           
  Lines             ?    50970           
  Branches          ?        0           
=========================================
  Hits              ?    46991           
  Misses            ?     3979           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.62% <ø> (?)
#single 42.25% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cac923...093b2c9. Read the comment docs.

@jreback jreback merged commit f27cd71 into pandas-dev:master Oct 23, 2018
@tswast tswast mentioned this pull request Oct 23, 2018
2 tasks
@tswast
Copy link
Contributor

tswast commented Oct 23, 2018

PR for gbq tests: #23303

JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Oct 23, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Data IO issues that don't fit into a more specific label Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants