Skip to content

Categorical take fill value #23297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2018
Merged

Categorical take fill value #23297

merged 3 commits into from
Oct 23, 2018

Conversation

TomAugspurger
Copy link
Contributor

Closes #23296

@pep8speaks
Copy link

pep8speaks commented Oct 23, 2018 •
edited
Loading

Hello @TomAugspurger! Thanks for updating the PR.

Comment last updated on October 23, 2018 at 14:07 Hours UTC

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Oct 23, 2018
@TomAugspurger TomAugspurger added the Categorical Categorical Data Type label Oct 23, 2018
@TomAugspurger
Copy link
Contributor Author

Ah, forgot to revert a change. 1 sec.

@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Oct 23, 2018
jreback
jreback approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

@codecov
Copy link

codecov bot commented Oct 23, 2018 •
edited
Loading

Codecov Report

Merging #23297 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23297      +/-   ##
==========================================
+ Coverage   92.22%   92.22%   +<.01%     
==========================================
  Files         169      169              
  Lines       50897    50903       +6     
==========================================
+ Hits        46940    46946       +6     
  Misses       3957     3957
Flag Coverage Δ
#multiple 90.65% <100%> (ø) ⬆️
#single 42.29% <28.57%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.56% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0c91e...fb64335. Read the comment docs.

@TomAugspurger TomAugspurger merged commit a6fb0ab into pandas-dev:master Oct 23, 2018
@TomAugspurger TomAugspurger deleted the categorical-take-fill-value branch October 23, 2018 19:52
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@TomAugspurger @tm9k1
Categorical take fill value (pandas-dev#23297)
74b5a8f 
* BUG: Handle fill_value in Categorical.take

Closes pandas-dev#23296

* no new categories

* revert add_categories
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
Categorical take fill value (pandas-dev#23297)
5497ea0 
* BUG: Handle fill_value in Categorical.take

Closes pandas-dev#23296

* no new categories

* revert add_categories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAugspurger @pep8speaks @jreback