Skip to content

style: fix import format at pandas/core/reshape #23387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2018
Merged

style: fix import format at pandas/core/reshape #23387

merged 5 commits into from
Nov 1, 2018

Conversation

streeck
Copy link
Contributor

@streeck streeck commented Oct 27, 2018 •
edited
Loading

@pep8speaks
Copy link

Hello @streeck! Thanks for submitting the PR.

@gfyoung gfyoung added the Code Style Code style, linting, code_checks label Oct 27, 2018
@thoo
Copy link
Contributor

thoo commented Oct 28, 2018

@streeck You got error in Travis due to /pandas/core/reshape/pivot.py:25:1: E303 too many blank lines (3) . You can locally run flake8 on pivot.py to make sure it is in a proper format.

@codecov
Copy link

codecov bot commented Oct 29, 2018 •
edited
Loading

Codecov Report

Merging #23387 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23387      +/-   ##
==========================================
- Coverage   92.21%   92.21%   -0.01%     
==========================================
  Files         161      161              
  Lines       51173    51171       -2     
==========================================
- Hits        47190    47188       -2     
  Misses       3983     3983
Flag Coverage Δ
#multiple 90.65% <100%> (-0.01%) ⬇️
#single 42.23% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/pivot.py 96.55% <100%> (ø) ⬆️
pandas/core/reshape/reshape.py 99.54% <100%> (-0.01%) ⬇️
pandas/core/reshape/concat.py 97.6% <100%> (ø) ⬆️
pandas/core/reshape/util.py 100% <100%> (ø) ⬆️
pandas/core/reshape/merge.py 94.01% <100%> (ø) ⬆️
pandas/core/reshape/tile.py 94.73% <100%> (ø) ⬆️
pandas/core/reshape/api.py 100% <100%> (ø) ⬆️
pandas/core/reshape/melt.py 97.32% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de39bfc...f5d5b29. Read the comment docs.

@streeck
Copy link
Contributor Author

streeck commented Oct 29, 2018

Thanks for the catch @thoo, made the changes for that file, builds are all green now 😃

@jreback
Copy link
Contributor

jreback commented Oct 29, 2018

can you merge master, we just updated the isort cfg

@streeck
Copy link
Contributor Author

streeck commented Oct 29, 2018

Done 👍

@jreback
Copy link
Contributor

jreback commented Oct 30, 2018

not passing, pls see if you can fix up.

@streeck
Copy link
Contributor Author

streeck commented Oct 30, 2018 •
edited
Loading

Looks like I need to run the sort of imports again for some reason 🤔
Will do it later today.

@jreback
Copy link
Contributor

jreback commented Oct 31, 2018

yes, the isort config changed slightly to reorder some things. pls ping on your open PR's when done.

@streeck
Copy link
Contributor Author

streeck commented Oct 31, 2018

@jreback This one looks like it's good to go again 😃

@jreback jreback added this to the 0.24.0 milestone Nov 1, 2018
@jreback jreback merged commit 9019582 into pandas-dev:master Nov 1, 2018
@jreback
Copy link
Contributor

jreback commented Nov 1, 2018

thanks!

thoo added a commit to thoo/pandas that referenced this pull request Nov 3, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into check_np_pd_fromE…
5d785c3 
…xamples

* repo_org/master: (66 commits)
  CLN: doc string (pandas-dev#23469)
  DOC: Add cookbook entry for triangular correlation matrix (GH22840) (pandas-dev#23032)
  add number of Errors, Warnings to scripts/validate_docstrings.py (pandas-dev#23150)
  BUG: Allow freq conversion from dt64 to period (pandas-dev#23460)
  ENH: Add FrozenList.union and .difference (pandas-dev#23394)
  REF: cython cleanup, typing, optimizations (pandas-dev#23464)
  strictness and checks for Timedelta _simple_new (pandas-dev#23433)
  Fixing flake8 problems new to flake8 3.6.0 (pandas-dev#23472)
  DOC: Updating the docstring of Series.dot  (pandas-dev#22890)
  TST: Fixturize series/test_analytics.py (pandas-dev#22755)
  BUG/ENH: Handle NonexistentTimeError in date rounding (pandas-dev#23406)
  PERF: speed up concat on Series by making _get_axis_number() a classmethod (pandas-dev#23404)
  REF: Remove DatetimelikeArrayMixin._shallow_copy (pandas-dev#23430)
  REF: strictness/simplification in DatetimeArray/Index _simple_new (pandas-dev#23431)
  REF: cython cleanup, typing, optimizations (pandas-dev#23456)
  TST: tweak Hypothesis configuration and idioms (pandas-dev#23441)
  BUG: fix HDFStore.append with all empty strings error (GH12242) (pandas-dev#23435)
  TST: Skip 32bit failing IntervalTree tests (pandas-dev#23442)
  BUG: Deprecate nthreads argument (pandas-dev#23112)
  style: fix import format at pandas/core/reshape (pandas-dev#23387)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@streeck @tm9k1
style: fix import format at pandas/core/reshape (pandas-dev#23387)
866f1eb
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@streeck @Pingviinituutti
style: fix import format at pandas/core/reshape (pandas-dev#23387)
2c80560
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@streeck @Pingviinituutti
style: fix import format at pandas/core/reshape (pandas-dev#23387)
02d457c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@streeck @pep8speaks @thoo @jreback @gfyoung