Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Deprecate FrozenNDArray #23396

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 28, 2018

Rationale can be found here.

Closes #9031.

xref #14565 (potentially can close this given how central FrozenNDArray was to discussion)

@gfyoung gfyoung added API Design Deprecate Functionality to remove in pandas Frozen labels Oct 28, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Oct 28, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@gfyoung gfyoung force-pushed the frozen-ndarray-depr branch from c0d2362 to 41cf7d1 Compare October 28, 2018 08:24
@gfyoung gfyoung force-pushed the frozen-ndarray-depr branch from 41cf7d1 to f04d9e2 Compare October 28, 2018 21:14
@codecov
Copy link

codecov bot commented Oct 28, 2018

Codecov Report

Merging #23396 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23396      +/-   ##
==========================================
+ Coverage   92.18%   92.18%   +<.01%     
==========================================
  Files         161      161              
  Lines       51155    51157       +2     
==========================================
+ Hits        47157    47159       +2     
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 42.24% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/compat/pickle_compat.py 75.6% <ø> (ø) ⬆️
pandas/core/indexes/multi.py 95.46% <100%> (ø) ⬆️
pandas/core/indexes/frozen.py 91.66% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26005a...f04d9e2. Read the comment docs.

@jreback jreback merged commit 218389b into pandas-dev:master Oct 30, 2018
@jreback
Copy link
Contributor

jreback commented Oct 30, 2018

thanks! can you add to the deprecated issue (put remove in 1.0)

@gfyoung gfyoung deleted the frozen-ndarray-depr branch October 30, 2018 16:52
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung gfyoung mentioned this pull request Nov 2, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FrozenNDArray cannot repr scalars
3 participants