-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Update description of Index._values/values/ndarray_values #23507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update description of Index._values/values/ndarray_values #23507
Conversation
Hello @jorisvandenbossche! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23507 +/- ##
=========================================
Coverage ? 92.23%
=========================================
Files ? 161
Lines ? 51197
Branches ? 0
=========================================
Hits ? 47220
Misses ? 3977
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbrockmendel : If this looks good to you, go and merge!
pandas/core/indexes/base.py
Outdated
index | values | _values | _ndarray_values | | ||
----------------- | --------------- | ------------- | --------------- | | ||
Index | ndarray | ndarray | ndarray | | ||
CategoricalIndex | Categorical | Categorical | codes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codes -> ndarray[int]
closes #23504
@jbrockmendel @TomAugspurger