BUG: Fix read_excel w/parse_cols & empty dataset

[gfyoung]

Closes #9208.

[pep8speaks]

Hello @gfyoung! Thanks for submitting the PR.

• There are no PEP8 issues in the file pandas/io/excel.py !

• There are no PEP8 issues in the file pandas/tests/io/test_excel.py !

[codecov]

Codecov Report

Merging #23661 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23661   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51317    51317           
=======================================
  Hits        47338    47338           
  Misses       3979     3979

Flag	Coverage Δ
#multiple	90.63% <ø> (ø)	⬆️
#single	42.31% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bdb3e...13abef8. Read the comment docs.

[TomAugspurger]

LGTM: just one small question.

What are the changes to the excel file?

[TomAugspurger]

That's what I was hoping :) +1

…

On Tue, Nov 13, 2018 at 8:00 AM gfyoung ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pandas/io/excel.py <#23661 (comment)>: > @@ -634,14 +634,17 @@ def _parse_cell(cell_contents, cell_typ): else: offset = 1 + max(header) - for col in index_col: - last = data[offset][col] - - for row in range(offset + 1, len(data)): - if data[row][col] == '' or data[row][col] is None: - data[row][col] = last - else: - last = data[row][col] + # Check if we have an empty dataset + # before trying to collect data. + if offset < len(data): What are the changes to the excel file? To add a test that addresses your question: Do we have a test where offset is equal to len(data)? Don't worry, I accounted for the off-by-one 😉 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23661 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIkj7BfvgfE1ziQ8dXDqG8bhez2g0ks5uutBkgaJpZM4Ya6xX> .