WIP/DEPR: Deprecate inplace=True #24063
Conversation
|
Hello @datapythonista! Thanks for submitting the PR.
|
| @@ -1136,7 +1136,11 @@ def reset_index(self, level=None, drop=False, name=None, inplace=False): | |||
| values. Uses ``self.name`` by default. This argument is ignored | |||
| when `drop` is True. | |||
| inplace : bool, default False | |||
| Modify the Series in place (do not create a new object). | |||
| Update the caller instead of returning a new object. | |||
There was a problem hiding this comment.
maybe want to update the Returns to say that inplace returns None
| Update the caller instead of returning a new object. | ||
|
|
||
| .. deprecated:: 0.24.0 | ||
| Use ``s = s.reset_index()`` instead of |
There was a problem hiding this comment.
looks ok, is this how we do it elsewhere?
Codecov Report
@@ Coverage Diff @@
## master #24063 +/- ##
===========================================
- Coverage 92.31% 42.44% -49.87%
===========================================
Files 161 161
Lines 51562 51565 +3
===========================================
- Hits 47599 21887 -25712
- Misses 3963 29678 +25715
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24063 +/- ##
===========================================
- Coverage 92.31% 42.44% -49.87%
===========================================
Files 161 161
Lines 51562 51565 +3
===========================================
- Hits 47599 21887 -25712
- Misses 3963 29678 +25715
Continue to review full report at Codecov.
|
|
Closing this for now, will reopen if makes sense after we finish discussing #16529. |
git diff upstream/master -u -- "*.py" | flake8 --diff@jreback can you take a look and let me know if you're happy with the way I'm deprecating
inplace=Truehere? I need to repeat the same lots of time, so would be nice to have any changes requested here, and not when they need to be repeated 100 times. :)