-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Remove doc spellcheck #24287
DOC: Remove doc spellcheck #24287
Conversation
Hello @datapythonista! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #24287 +/- ##
===========================================
- Coverage 92.22% 43% -49.22%
===========================================
Files 162 162
Lines 51824 51824
===========================================
- Hits 47795 22289 -25506
- Misses 4029 29535 +25506
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24287 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 162 162
Lines 51824 51824
=======================================
Hits 47795 47795
Misses 4029 4029
Continue to review full report at Codecov.
|
thanks! |
can you do a followup to remove sphinxcontrib-spelling from any of the ci & environment.yml & also remove the spelling section from the contributing guide. thanks. |
The spellcheck system was implemented, but with dependencies (i.e.
enchant
) that are no longer maintained, and there is no reasonable way to set them up. This means that can't be added to the CI, and can't be even set up into our local environments with a decent amount of work installing dependencies manually (I didn't succeed).The PR that was trying to finish the work on the spellcheck, #21402, was finally discarded, but part of the stuff is still in sphinx, just generating a warning when trying to get the sphinx extension.
This PR removes it.