Skip to content

Cython language level 3 #24538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 19, 2019
Merged

Cython language level 3 #24538

merged 8 commits into from
Mar 19, 2019

Conversation

@WillAyd
Copy link
Member

@WillAyd WillAyd commented Jan 1, 2019

@jreback jreback added Build Library building on various platforms 2/3 Compat labels Jan 1, 2019
@jreback
Copy link
Contributor

jreback commented Jan 1, 2019

lgtm. ping on green.

@jreback jreback added this to the 0.24.0 milestone Jan 1, 2019
jbrockmendel
jbrockmendel reviewed Jan 1, 2019
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are places where we do isinstance Unicode checks, may be worth updating

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #24538 into master will decrease coverage by 49.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24538      +/-   ##
==========================================
- Coverage   92.32%   43.02%   -49.3%     
==========================================
  Files         166      166              
  Lines       52429    52429              
==========================================
- Hits        48403    22557   -25846     
- Misses       4026    29872   +25846
Flag Coverage Δ
#multiple ?
#single 43.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-98.68%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945445d...15fcf0b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 1, 2019 •
edited
Loading

Codecov Report

Merging #24538 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24538   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         172      172           
  Lines       52977    52977           
=======================================
  Hits        48342    48342           
  Misses       4635     4635
Flag Coverage Δ
#multiple 89.82% <ø> (ø) ⬆️
#single 41.74% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707c720...b7ccc62. Read the comment docs.

@WillAyd
Copy link
Member Author

WillAyd commented Jan 1, 2019

I think there are places where we do isinstance Unicode checks, may be worth updating

Yep I do see a few. Going to try and get green as is first then do this on a subsequent pass

@jreback jreback removed this from the 0.24.0 milestone Jan 2, 2019
@WillAyd
Copy link
Member Author

WillAyd commented Jan 2, 2019

All failures are for the 2.7 builds; are we still worrying about them at this point?

@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

only if you want to merge this for 0.24

@jreback jreback added this to the 0.25.0 milestone Jan 2, 2019
@WillAyd
Copy link
Member Author

WillAyd commented Jan 2, 2019

I don't think it necessarily adds anything to 0.24 from an end user perspective so fine to wait on my end

@WillAyd
Copy link
Member Author

WillAyd commented Jan 8, 2019

Just rebasing to minimize diff in future; no rush for action here

@tacaswell tacaswell mentioned this pull request Feb 4, 2019
Merged
4 tasks
@WillAyd
Copy link
Member Author

WillAyd commented Mar 18, 2019

@jreback I think timing is finally right for merge here.

To @jbrockmendel point above there are still some isinstance unicode checks that could be cleaned up, but I figure that's better left in follow ups to rip out Py2 compat. This as is is minimum to get language level switched over to 3 syntax

@jreback jreback merged commit 90617c6 into pandas-dev:master Mar 19, 2019
@jreback
Copy link
Contributor

jreback commented Mar 19, 2019

thanks @WillAyd

sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 20, 2019
@sighingnow
Merge remote-tracking branch 'origin/master' into fix-25557
bce25c9 
* origin/master:
  DOC: clean bug fix section in whatsnew (pandas-dev#25792)
  DOC: Fixed PeriodArray api ref (pandas-dev#25526)
  Move locale code out of tm, into _config (pandas-dev#25757)
  Unpin pycodestyle (pandas-dev#25789)
  Add test for rdivmod on EA array (GH23287) (pandas-dev#24047)
  ENH: Support datetime.timezone objects (pandas-dev#25065)
  Cython language level 3 (pandas-dev#24538)
  API: concat on sparse values (pandas-dev#25719)
  TST: assert_produces_warning works with filterwarnings (pandas-dev#25721)
  make core.config self-contained (pandas-dev#25613)
  CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721)
  TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)
  DOC: Fix typo in docstring of DataFrame.memory_usage  (pandas-dev#25770)
  Replace dicts with OrderedDicts in groupby aggregation functions (pandas-dev#25693)
  TST: Fixturize tests/frame/test_missing.py (pandas-dev#25640)
  DOC: Improve the docsting of Series.iteritems (pandas-dev#24879)
  DOC: Fix function name. (pandas-dev#25751)
  Implementing iso_week_year support for to_datetime (pandas-dev#25541)
  DOC: clarify corr behaviour when using a callable (pandas-dev#25732)
  remove unnecessary check_output (pandas-dev#25755)

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
@kohr-h kohr-h mentioned this pull request May 4, 2019
Open
3 tasks
@WillAyd WillAyd deleted the cython-3-compat branch January 16, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees

No one assigned

Labels

Build Library building on various platforms

Projects

None yet

Milestone

0.25.0

Development

Successfully merging this pull request may close these issues.

Cython language_level Warning - switch to Python3?

3 participants

@WillAyd @jreback @jbrockmendel