Skip to content

BUG: TypeError with to_html(sparsify=False) and max_cols < len(columns) #24572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Jan 2, 2019

@jreback jreback added Bug IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Jan 2, 2019
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

looks good can you add a whatsnew note

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24572 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24572      +/-   ##
==========================================
+ Coverage   92.31%   92.31%   +<.01%     
==========================================
  Files         166      166              
  Lines       52556    52559       +3     
==========================================
+ Hits        48518    48522       +4     
+ Misses       4038     4037       -1
Flag Coverage Δ
#multiple 90.74% <100%> (ø) ⬆️
#single 43.06% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/html.py 99.36% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588b558...65213f9. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24572 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24572      +/-   ##
==========================================
+ Coverage   92.31%   92.32%   +<.01%     
==========================================
  Files         166      166              
  Lines       52556    52559       +3     
==========================================
+ Hits        48518    48523       +5     
+ Misses       4038     4036       -2
Flag Coverage Δ
#multiple 90.74% <100%> (ø) ⬆️
#single 43.05% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/html.py 99.36% <100%> (+0.32%) ⬆️
pandas/util/testing.py 87.71% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588b558...56b4aae. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Jan 3, 2019
@jreback jreback merged commit a422da1 into pandas-dev:master Jan 3, 2019
@jreback
Copy link
Contributor

jreback commented Jan 3, 2019

thanks!

@simonjayhawkins simonjayhawkins deleted the sparse branch January 3, 2019 00:56
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError with to_html(sparsify=False) and max_cols < len(columns) TST: random html testing issues
2 participants