Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: use pytest.raises context syntax #24655

Merged
merged 3 commits into from
Jan 8, 2019

Conversation

simonjayhawkins
Copy link
Member

xref #24332

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Jan 7, 2019
@gfyoung
Copy link
Member

gfyoung commented Jan 7, 2019

I like what you're doing here. Getting the error messages right can sometimes be tricky though...

(Trust me, I've had to hack through some of these myself recently 😉 )

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #24655 into master will decrease coverage by 49.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24655       +/-   ##
===========================================
- Coverage   92.37%   43.02%   -49.36%     
===========================================
  Files         166      166               
  Lines       52384    52384               
===========================================
- Hits        48391    22539    -25852     
- Misses       3993    29845    +25852
Flag Coverage Δ
#multiple ?
#single 43.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.35%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4994ca...4e83d9b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #24655 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24655      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52384    52382       -2     
==========================================
- Hits        48391    48389       -2     
  Misses       3993     3993
Flag Coverage Δ
#multiple 90.8% <ø> (-0.01%) ⬇️
#single 43.01% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/window.py 96.4% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4994ca...3aff8d9. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Jan 8, 2019
@jreback jreback merged commit f13859d into pandas-dev:master Jan 8, 2019
@jreback
Copy link
Contributor

jreback commented Jan 8, 2019

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the pytest-raises branch January 8, 2019 19:52
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* STY: use pytest.raises context syntax

* fix CI failures

* fix CI failures
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
* STY: use pytest.raises context syntax

* fix CI failures

* fix CI failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants