-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Sphinx RTD Theme #25614
Use Sphinx RTD Theme #25614
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25614 +/- ##
==========================================
- Coverage 91.26% 91.26% -0.01%
==========================================
Files 173 173
Lines 52968 52968
==========================================
- Hits 48340 48339 -1
- Misses 4628 4629 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25614 +/- ##
==========================================
- Coverage 91.26% 91.26% -0.01%
==========================================
Files 173 173
Lines 52968 52968
==========================================
- Hits 48340 48339 -1
- Misses 4628 4629 +1
Continue to review full report at Codecov.
|
Should we be re-styling the website at the same time as the docs? Or would people be OK with changing those at different times? @WillAyd have you looked at the http://pandas-docs.github.io/pandas-docs-travis/user_guide/style.html page with this theme? Does it look OK? |
@TomAugspurger sorry just seeing this now. That theme looks OK to me! I'm not terribly tied to the this PR but opened because:
If there's not an appetite for it though certainly can close |
To answer this explicitly I think different times is fine. I don't see a super tight harmony between existing site and docs (though more than RTD) and wouldn't want to try a super big change at once. |
That's fair. Thoughts on holding off on this till we hear if we line up someone to work on our docs as part of that NUMFocus grant? |
Yep works for me - no real urgency here.
…Sent from my iPhone
On Mar 14, 2019, at 2:26 PM, Tom Augspurger ***@***.***> wrote:
That's fair.
Thoughts on holding off on this till we hear if we line up someone to work on our docs as part of that NUMFocus grant?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
TOC on the left hand side is pinned during navigation and also expandable/collapsible