CLN: Removed second version of xstrtod in parser_helper.h

[anmyachev]

• closes Duplicate xstrtod implementations #19361
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[codecov]

Codecov Report

Merging #25925 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25925      +/-   ##
==========================================
- Coverage    91.8%   91.79%   -0.01%     
==========================================
  Files         174      174              
  Lines       52536    52536              
==========================================
- Hits        48231    48226       -5     
- Misses       4305     4310       +5

Flag	Coverage Δ
#multiple	90.35% <ø> (ø)	⬆️
#single	41.88% <ø> (-0.07%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	75% <0%> (-12.5%)	⬇️
pandas/core/frame.py	96.79% <0%> (-0.12%)	⬇️
pandas/util/testing.py	90.63% <0%> (-0.11%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4c89f...d7c6ffa. Read the comment docs.

[codecov]

Codecov Report

Merging #25925 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25925      +/-   ##
==========================================
- Coverage   91.81%    91.8%   -0.01%     
==========================================
  Files         175      175              
  Lines       52578    52578              
==========================================
- Hits        48273    48269       -4     
- Misses       4305     4309       +4

Flag	Coverage Δ
#multiple	90.36% <ø> (ø)	⬆️
#single	41.9% <ø> (-0.08%)	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	75% <0%> (-12.5%)	⬇️
pandas/core/frame.py	96.79% <0%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ba498...7d56a15. Read the comment docs.

[gfyoung]

@anmyachev : Thanks for the PR!

Can you run asv benchmarks to see if performance is impacted with this de-duplication?

[jbrockmendel]

AFAICT this looks fine, but I'm going to kick the review over to @chris-b1 who is better-versed in this area.

[gfyoung]

@jbrockmendel: Sounds good. Was just pinging for the modified dependency linking (given your thoughts interest in reorganizing internal dependencies to make it more DAG)

[anmyachev]

@gfyoung after this run:
asv continuous -f 1.01 origin/master HEAD -e -b inference.MaybeConvertNumeric
result: BENCHMARKS NOT SIGNIFICANTLY CHANGED.
Same result for run asv continuous -f 1.01 origin/master HEAD -e -b io.csv

• First run check perf of xstrtod with maybe_int != NULL
• Second run check perf of xstrtod with maybe_int == NULL

[jreback]

@chris-b1 any comments here

[chris-b1]

lgtm!

[jreback]

thanks @anmyachev