BUG: fallback from issue 20824 no longer occurs due to skipna flag #26176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukundm19
changed the title
Codecov Report
@@ Coverage Diff @@
## master #26176 +/- ##
==========================================
- Coverage 91.98% 91.96% -0.02%
==========================================
Files 175 175
Lines 52371 52380 +9
==========================================
- Hits 48175 48173 -2
- Misses 4196 4207 +11
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26176 +/- ##
==========================================
- Coverage 91.98% 91.96% -0.02%
==========================================
Files 175 175
Lines 52371 52380 +9
==========================================
- Hits 48175 48173 -2
- Misses 4196 4207 +11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffIssue #20824 found that a fallback was occuring when df.Groupby().sum() was called with the skipna flag. This was occurring because the _cython_agg_general function was not accepting the argument, which has now been fixed. The fallback still occurs with strings in the df, however this is a deeper issue stemming from the _aggregate() call in groupby/ops.py (line 572).