Skip to content

Fix .transform crash when SeriesGroupBy is empty (#26208) #26228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 15, 2019
Merged

Fix .transform crash when SeriesGroupBy is empty (#26208) #26228

merged 11 commits into from
May 15, 2019

Conversation

HHest
Copy link
Contributor

@HHest HHest commented Apr 27, 2019

@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #26228 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26228      +/-   ##
==========================================
- Coverage   91.97%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52379    52381       +2     
==========================================
- Hits        48178    48176       -2     
- Misses       4201     4205       +4
Flag Coverage Δ
#multiple 90.52% <100%> (ø) ⬆️
#single 40.7% <0%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby/generic.py 89.05% <100%> (+0.02%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64104ec...d86d07b. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #26228 into master will decrease coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26228      +/-   ##
==========================================
- Coverage   92.04%   91.68%   -0.36%     
==========================================
  Files         175      174       -1     
  Lines       52289    50751    -1538     
==========================================
- Hits        48130    46532    -1598     
- Misses       4159     4219      +60
Flag Coverage Δ
#multiple 90.19% <100%> (-0.4%) ⬇️
#single 41.16% <0%> (+0.3%) ⬆️
Impacted Files Coverage Δ
pandas/core/groupby/generic.py 89.03% <100%> (+0.02%) ⬆️
pandas/core/panel.py 17.49% <0%> (-17.65%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/compat/numpy/function.py 90.39% <0%> (-0.41%) ⬇️
pandas/core/generic.py 93.34% <0%> (-0.24%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/core/series.py 93.67% <0%> (ø) ⬆️
pandas/io/parsers.py
pandas/core/indexes/base.py 96.72% <0%> (ø) ⬆️
pandas/core/arrays/integer.py 96.35% <0%> (+0.02%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971dcc1...807b7cc. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Apr 28, 2019

can you check if we have an open issue for this?

@HHest
Copy link
Contributor Author

HHest commented May 3, 2019

can you check if we have an open issue for this?

Yes it is #26208

@HHest HHest closed this May 4, 2019
@HHest HHest reopened this May 4, 2019
@pep8speaks
Copy link

pep8speaks commented May 14, 2019

Hello @HHest! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-14 17:10:18 UTC

@jreback jreback added this to the 0.25.0 milestone May 14, 2019
@jreback
Copy link
Contributor

jreback commented May 14, 2019

@HHest lgtm. ping on green.

@HHest
Copy link
Contributor Author

HHest commented May 14, 2019

sd

@HHest lgtm. ping on green.

Thank you very much. Green.

@jreback jreback merged commit ff4437e into pandas-dev:master May 15, 2019
@jreback
Copy link
Contributor

jreback commented May 15, 2019

thanks @HHest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SeriesGroupBy.transform cannot handle empty series
5 participants