Skip to content

PERF: Add if branch for empty sep in str.cat #26605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2019
Merged

PERF: Add if branch for empty sep in str.cat #26605

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e0d03a
PERF: Add if branch for empty sep in str.cat
h-vetinari Dec 2, 2018
c1083f4
blackify
h-vetinari Jul 30, 2019
637686b
add comment
h-vetinari Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ def cat_core(list_of_columns: List, sep: str):
nd.array
The concatenation of list_of_columns with sep
"""
if sep == "":
# no need to interleave sep if it is empty
return np.sum(list_of_columns, axis=0)
list_with_sep = [sep] * (2 * len(list_of_columns) - 1)
list_with_sep[::2] = list_of_columns
return np.sum(list_with_sep, axis=0)
Expand Down