Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: clean-up numpydoc patches now numpydoc 0.9 is released #26785

Conversation

jorisvandenbossche
Copy link
Member

Since numpydoc is released, we can do some cleanup of what was introduced in #24098

cc @FHaase

@jorisvandenbossche jorisvandenbossche added this to the 0.25.0 milestone Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #26785 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26785      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         178      178              
  Lines       50779    50779              
==========================================
- Hits        46579    46575       -4     
- Misses       4200     4204       +4
Flag Coverage Δ
#multiple 90.31% <ø> (ø) ⬆️
#single 41.18% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea06f8d...ab84356. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #26785 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26785      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         178      178              
  Lines       50779    50779              
==========================================
- Hits        46579    46575       -4     
- Misses       4200     4204       +4
Flag Coverage Δ
#multiple 90.31% <ø> (ø) ⬆️
#single 41.21% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea06f8d...96deed4. Read the comment docs.

@jorisvandenbossche
Copy link
Member Author

This also resolves a bunch of the current build warnings! (down from 330 to 204 ;-))

@jorisvandenbossche
Copy link
Member Author

cc @datapythonista this resolves a bunch of warnings that I was (unsuccessfully ..) trying to find the cause for

@jorisvandenbossche
Copy link
Member Author

The failure is unrelated (a crash in one of the tests). If it occurs more, something to investigate though.

@jorisvandenbossche jorisvandenbossche merged commit b8ad9da into pandas-dev:master Jun 11, 2019
@jorisvandenbossche jorisvandenbossche deleted the cleanup-numpydoc-patches branch June 11, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant