Skip to content

Bump minimum verions #26832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Conversation

TomAugspurger
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #26832 into master will increase coverage by 1.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #26832     +/-   ##
=========================================
+ Coverage   90.45%   91.86%   +1.4%     
=========================================
  Files         179      179             
  Lines       50706    50706             
=========================================
+ Hits        45866    46579    +713     
+ Misses       4840     4127    -713
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 41.12% <ø> (?)
Impacted Files Coverage Δ
pandas/compat/_optional.py 100% <ø> (ø) ⬆️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️
pandas/core/arrays/categorical.py 95.92% <0%> (+0.12%) ⬆️
pandas/core/indexes/datetimes.py 96.37% <0%> (+0.16%) ⬆️
pandas/io/formats/printing.py 85.56% <0%> (+1.06%) ⬆️
pandas/io/clipboard/clipboards.py 34.78% <0%> (+2.89%) ⬆️
pandas/core/computation/expr.py 97.8% <0%> (+3.02%) ⬆️
pandas/core/computation/common.py 89.47% <0%> (+5.26%) ⬆️
pandas/io/pytables.py 90.29% <0%> (+26.47%) ⬆️
pandas/core/computation/pytables.py 90.24% <0%> (+27.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8132a2...fa0c6b9. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #26832 into master will increase coverage by 1.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #26832     +/-   ##
=========================================
+ Coverage   90.45%   91.85%   +1.4%     
=========================================
  Files         179      179             
  Lines       50706    50706             
=========================================
+ Hits        45866    46578    +712     
+ Misses       4840     4128    -712
Flag Coverage Δ
#multiple 90.45% <ø> (ø) ⬆️
#single 41.1% <ø> (?)
Impacted Files Coverage Δ
pandas/compat/_optional.py 100% <ø> (ø) ⬆️
pandas/core/arrays/categorical.py 95.92% <0%> (+0.12%) ⬆️
pandas/core/indexes/datetimes.py 96.37% <0%> (+0.16%) ⬆️
pandas/io/formats/printing.py 85.56% <0%> (+1.06%) ⬆️
pandas/io/clipboard/clipboards.py 34.78% <0%> (+2.89%) ⬆️
pandas/core/computation/expr.py 97.8% <0%> (+3.02%) ⬆️
pandas/core/computation/common.py 89.47% <0%> (+5.26%) ⬆️
pandas/io/pytables.py 90.29% <0%> (+26.47%) ⬆️
pandas/core/computation/pytables.py 90.24% <0%> (+27.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8132a2...297025f. Read the comment docs.

@@ -100,6 +100,28 @@ Other Enhancements
- :class:`DatetimeIndex` and :class:`TimedeltaIndex` now have a ``mean`` method (:issue:`24757`)
- :meth:`DataFrame.describe` now formats integer percentiles without decimal point (:issue:`26660`)

.. _whatsnew_0250.dependencies:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you merge this with the existing section

Increased minimum versions for dependencies
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these as part of the numpy 1.13 bump

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops forgot about that.

@jreback jreback added the Dependencies Required and optional dependencies label Jun 13, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 13, 2019
@TomAugspurger
Copy link
Contributor Author

All green.

================================================================ ==========================
Package Minimum supported version
================================================================ ==========================
`setuptools <https://setuptools.readthedocs.io/en/latest/>`__ 24.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should bump this too, but orthogonal

@jreback jreback merged commit a60888c into pandas-dev:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants