-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
NDFrame.filter -> NDFrame.select #26866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26866 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.01%
==========================================
Files 179 179
Lines 50696 50700 +4
==========================================
- Hits 46581 46580 -1
- Misses 4115 4120 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26866 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.01%
==========================================
Files 179 179
Lines 50696 50700 +4
==========================================
Hits 46581 46581
- Misses 4115 4119 +4
Continue to review full report at Codecov.
|
192fa91
to
69c37a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have a discussion about these semantics in the issue, can you summarize there
We need to have at least one release without NDFrame.select, before we can change it to be the new name for filter, right? |
I've set up an issue at #26642. |
I'm closing this donw temporarily. As I'vr said in #26642, I'm in favor ofmaking a specialized method that wouldn't overlap too much |
git diff upstream/master -u -- "*.py" | flake8 --diff
This PR moves
NDFrame.filter
over toNDFrame.select
and deprecatesNDFrame.filter
.I'm not completely happy with the siganture from
.filter
, and got some discussion points in #26642. The current PR can be seen as a first version, to be changed, if there's agreement,