Skip to content

Add docstring to the insertion method & add empty result note #26872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 3, 2019
Merged

Add docstring to the insertion method & add empty result note #26872

merged 5 commits into from
Sep 3, 2019

Conversation

oguzhanogreden
Copy link
Contributor

@oguzhanogreden oguzhanogreden commented Jun 15, 2019 •
edited by jreback
Loading

closes #21364
closes #26868

  • tests passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • What's new? Some small fixes in documentation.

@oguzhanogreden
Add docstring to the insertion method & fix #21364
ac281d6 
Credit for empty result documentation goes to @MagnetarAlex
jreback
jreback requested changes Jun 16, 2019
View reviewed changes
@jreback jreback added Docs IO SQL to_sql, read_sql, read_sql_query labels Jun 16, 2019
@WillAyd
Copy link
Member

WillAyd commented Aug 28, 2019

@oguzhanogreden can you address comments above?

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #26872 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26872      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         179      179              
  Lines       50696    50696              
==========================================
- Hits        46581    46577       -4     
- Misses       4115     4119       +4
Flag Coverage Δ
#multiple 90.46% <ø> (ø) ⬆️
#single 41.11% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430f0fd...7b1a796. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 29, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5f34933). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26872   +/-   ##
=========================================
  Coverage          ?   91.87%           
=========================================
  Files             ?      179           
  Lines             ?    50696           
  Branches          ?        0           
=========================================
  Hits              ?    46577           
  Misses            ?     4119           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.46% <ø> (?)
#single 41.11% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f34933...c82d53f. Read the comment docs.

@oguzhanogreden
Copy link
Contributor Author

Addressed the comments and updated with the current master.

@TomAugspurger TomAugspurger added this to the 1.0 milestone Sep 3, 2019
@TomAugspurger TomAugspurger merged commit afe0cc3 into pandas-dev:master Sep 3, 2019
@TomAugspurger
Copy link
Contributor

Thanks!

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@oguzhanogreden @proost
DOC: Add docstring to the insertion method & add empty result note (p…
d16b3c7 
…andas-dev#26872)

* Add docstring to the insertion method & fix pandas-dev#21364

Credit for empty result documentation goes to MagnetarAlex
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@oguzhanogreden @proost
DOC: Add docstring to the insertion method & add empty result note (p…
871c562 
…andas-dev#26872)

* Add docstring to the insertion method & fix pandas-dev#21364

Credit for empty result documentation goes to MagnetarAlex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Docs IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

DOC: Reference to type 'pd_table' in IO Tools User Guide pandas read_sql missing dtype on empty result
4 participants
@oguzhanogreden @WillAyd @TomAugspurger @jreback