Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: make Categorical.ravel() return Categorical #27199

Merged
merged 7 commits into from
Jul 3, 2019
Merged

DEPR: make Categorical.ravel() return Categorical #27199

merged 7 commits into from
Jul 3, 2019

Conversation

jbrockmendel
Copy link
Member

Discussed in #27142.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added Categorical Categorical Data Type Deprecate Functionality to remove in pandas labels Jul 3, 2019
@jsexauer jsexauer mentioned this pull request Jul 3, 2019
Closed
1 task
@jreback jreback added this to the 0.25.0 milestone Jul 3, 2019
@jreback
Copy link
Contributor

jreback commented Jul 3, 2019

conflict and failing

pandas/tests/extension/test_categorical.py(100,): error :  Found unwanted pattern:         with pytest.warns(FutureWarning, match="will return a Categorical")

otherwise lgtm.

@jbrockmendel jbrockmendel mentioned this pull request Jul 3, 2019
Closed
jreback
jreback reviewed Jul 3, 2019
View reviewed changes
pandas/tests/extension/base/base.py Outdated
@@ -2,6 +2,9 @@


class BaseExtensionTests:
# Whether the EA being tested supports __setitem__
_supports_setitem = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is ok, but in reality you should have a class which does this (future PR)

@jreback
Copy link
Contributor

jreback commented Jul 3, 2019

I am a little concerned by the change in testing pattern this introduces. Could we remove this for now.

@jbrockmendel
Copy link
Member Author

testing pattern reverted

@jreback
Copy link
Contributor

jreback commented Jul 3, 2019

lgtm. merge on green.

@jreback jreback merged commit 1659fff into pandas-dev:master Jul 3, 2019
@jreback
Copy link
Contributor

jreback commented Jul 3, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the catravel branch July 3, 2019 21:57
@jbrockmendel jbrockmendel mentioned this pull request Nov 29, 2019
Merged
@jreback jreback mentioned this pull request Dec 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @TomAugspurger