Skip to content

Fix compilation warnings #27371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from Jul 15, 2019
Merged

Fix compilation warnings #27371

merged 12 commits into from Jul 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2019

  • tests passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@WillAyd WillAyd added the Clean label Jul 12, 2019
@ghost ghost deleted a comment from WillAyd Jul 12, 2019
@ghost
Copy link
Author

ghost commented Jul 13, 2019

One of the fixes introduces a failing test on CI which I can't reproduce locally on either py37 or py35. Removed it for now.

@ghost
Copy link
Author

ghost commented Jul 13, 2019

One more fix added.

@ghost
Copy link
Author

ghost commented Jul 13, 2019

@WillAyd, ready.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreback jreback added this to the 0.25.0 milestone Jul 15, 2019
@jreback jreback merged commit b9d6433 into pandas-dev:master Jul 15, 2019
@ghost ghost deleted the warning branch July 15, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants