REF: implement module for shared constructor functions #27551
Conversation
| @@ -1,16 +1,51 @@ | |||
| """ | |||
| Constructor functions intended to be shared by pd.array, Series.__init__, | |||
There was a problem hiding this comment.
hmm, I would have left this where it was I think. what is the reasoning for moving this all to construction? (the array parts I am talking)
There was a problem hiding this comment.
after trying to move this back im remembering: because core.arrays.__init__ imports a bunch of stuff keeping it there makes import order a hassle
| @@ -278,3 +312,241 @@ def array( | |||
|
|
|||
| result = PandasArray._from_sequence(data, dtype=dtype, copy=copy) | |||
| return result | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
+1 on combing these routines into array module
There was a problem hiding this comment.
though im not wild about that name (hard to grep for)
|
@WillAyd help with mypy complaints? |
|
I think this is just starting to validate |
|
mypy fixed, thanks |
core.constructionintended for code to be shared betweenpd.array,Series.__init__, andIndex.__new__. The module should not need to be internals-aware.This only moves array and extract_array to keep the diff contained. The next step would be to move internals.construction.sanitize_array, which is used in a number of non-internals places and satisfies the not-internals-aware condition.
Several functions from core.dtypes.cast would also make more sense here than in their current locations.
update moved sanitize_array too, and updated imports