WEB: Adding new pandas website #28014

datapythonista · 2019-08-19T14:34:12Z

The website can be seen here: https://datapythonista.github.io/pandas-web/

It's still pending that the designer polish the styles. And also the content can surely be improved with everybody's feedback. But I think will be useful to merge this once we iterate a bit on people's feedback, so we can start working on integrating the docs.

I'm coordinating with the devs of numpy/scipy, scikit-learn and matplotlib to see if we can reshare things implemented here. Ideally I'd like to have the pysuerga.py script in a separate repo (that's why it's not named pandas_web.py`), and also the layout and pages that can be shared (the code of conduct, the donate, the blog,...). For now I add everything here for simplicity, and will create a new project and have it as a dependency here if they are interested.

CC: @pandas-dev/pandas-core

topper-123 · 2019-08-19T17:03:02Z

Looks good. Very clean layout.

A few comments:
1: The links to the docs don't work. That's perhaps in the works?

2: Is TideShift a Sponsor of Pandas now? Then they should be on the "with the support of..." list?

3: The link to Wes McKinney's book is http://www.kqzyfj.com/click-7040302-11260198?url=http%3A%2F%2Fshop.oreilly.com%2Fproduct%2F0636920050896.do&cjsku=0636920023784. Is there a reason for going through that http://www.kqzyfj.com link and not directly to oreilly.com? Looks a bit fishy going through redirects for web shopping, IMO.

datapythonista · 2019-08-20T09:29:34Z

Thanks for the review @topper-123, good feedback. I added Tidelift to the list of partners, and the docs links not working is intentional. I'm planning to add them after this is merged, and I make the docs use this same layout. Now they'd simply link to the current docs, and you'd leave the website.

Regarding Wes book, I guess that redirect was to keep track on the number of clicks. But besides looking fishy, clicking on it asks me to confirm that I accept some weird conditions, and after that it takes me to the home page of O'Reilly, not the book page (I guess that's because the 2nd edition has been released)_.

I updated the link to the direct link to the second edition, and also change the image to be the second edition front page. @wesm if you want to track clicks to the book, I think the best is to create a page in our own website that performs an automatic redirect, and track the visits with Google Analytics. Let me know if you want me to implement that.

wesm · 2019-08-20T12:58:01Z

web/pandas/index.html

+                </div>
+				<h4>Get the book</h4>
+				<p>
+					<a href="http://shop.oreilly.com/product/0636920050896.do">


If you want to change this to an affiliate link (so we receive ad fees), here is the one: https://amzn.to/2KI5JJw. I can donate annual proceeds from this link (probably not a lot in aggregate) to NumFOCUS

That makes sense, thank you. Updated.

mroeschke · 2019-08-20T17:24:50Z

From a mobile perspective, most everything rendered okay.

One consistent thing I noticed was that text was a little small for all pages:

Also this page didn't render too well:

Wouldn't say these are huge priorities, but keeping it on the radar.

datapythonista · 2019-08-20T17:31:15Z

Thanks for the feedback @mroeschke. I'll let the designer from Indeed take care of that. The website uses bootstrap, and should be very easy to make it responsive and look perfect in mobile. But I don't know exactly how it works, so I'll let her do it.

… by its svg format

datapythonista · 2019-08-29T14:06:43Z

Removed the carousel, and made couple of changes to reduce the size of the website files. There are couple of things I want to change to reduce the size further. After that, if there is no particular change requested, I think we should merge and continue with follow ups. This way we can work in parallel with the integration with the docs and the CI to display the dev version of the web.

The pending changes are:

Change Anaconda logo to a svg version (there are eps files that can be converted in https://www.anaconda.com/media-kit/)
Convert to jpeg and increase the compression of the files in the installation page. If anyone wants to propose changes to that page, now it's a good time, before we increase the size of the repo with unnecessary files.

…r project is interested in contributing it upstream

…page

datapythonista · 2019-09-12T16:35:29Z

I made the web responsive (couple of things still need to be changed to look perfect in mobile, but almost there).

Also removed the "try pandas" page for now and the blog (will focus on the core here, and add those as a follow up).

The version in https://datapythonista.github.io/pandas-web/ is almost the one I'd like to get merged here, and then work from there in other PRs. Any feedback welcome.

TomAugspurger · 2019-09-12T16:43:42Z

Glad to hear it.

Roughly speaking, what's the total size of the new files / assets here?

WillAyd · 2019-09-12T16:46:44Z

Just glanced briefly from phone where it looks really good. Just as a heads up though I think all of the doc pages are broken - at least navigating through gives a 404 https://datapythonista.github.io/pandas-web/docs/user_guide/ Sorry if I missed this on the call yesterday but how does this fit into what Stijn is doing? Would you want this merged as a precursor or does it replace some aspects?

…

Sent from my iPhone

On Sep 12, 2019, at 9:43 AM, Tom Augspurger ***@***.***> wrote: Glad to hear it. Roughly speaking, what's the total size of the new files / assets here? — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

TomAugspurger

Is the new web/pandas/static/img/pandas.svg the same as doc/logo/pandas_logo.svg?

TomAugspurger · 2019-09-12T16:46:48Z

web/pandas/community/contributing/index.md

+- [Setting up a development environment](setup.html)
+- [Working with git](git.md)
+- [Contributing to the documentation](docs.html)
+  - [Docstring guidelines](docstring_guidelines.html)


Looks like nested lists aren't handled properly? https://datapythonista.github.io/pandas-web/community/contributing/

Looks like markdown requires 4 spaces not 2, fixed

TomAugspurger · 2019-09-12T16:47:51Z

web/pandas/community/contributing/setup.md

+    to use 4 spaces for tabs.
+
+---
+The steps below will download around 900Mb for the pandas


Is 900Mb accurate?

Looks like it's 150 Mb for the repo, and 74 for conda dependencies. Not sure why those were wrong (that part is from the worldwide sprint). Fixed

TomAugspurger · 2019-09-12T16:49:02Z

web/pandas/community/ecosystem.md

+- ``vaex.from_pandas``
+- ``vaex.to_pandas_df``
+
+## Data validation


I think pyjanitor was recently added. May want to check for recent commits to these pages.

Updated, just couple of changes in the copied files.

TomAugspurger · 2019-09-12T16:53:09Z

I think these two can proceed mostly independently. Marc's is updating the website. Stijn's is updating the docs. We'll need to reconcile the styles by using a single CSS file for both, but that can be done afterwards I think. On Thu, Sep 12, 2019 at 11:46 AM William Ayd <notifications@github.com> wrote:

…

Just glanced briefly from phone where it looks really good. Just as a heads up though I think all of the doc pages are broken - at least navigating through gives a 404 https://datapythonista.github.io/pandas-web/docs/user_guide/ Sorry if I missed this on the call yesterday but how does this fit into what Stijn is doing? Would you want this merged as a precursor or does it replace some aspects? Sent from my iPhone > On Sep 12, 2019, at 9:43 AM, Tom Augspurger ***@***.***> wrote: > > Glad to hear it. > > Roughly speaking, what's the total size of the new files / assets here? > > — > You are receiving this because you are on a team that was mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#28014?email_source=notifications&email_token=AAKAOIU44MQQLID6UEJVLHLQJJW7XA5CNFSM4INCLXP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6SQXEQ#issuecomment-530910098>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIX6D3HK3FGLZKRM4Z3QJJW7XANCNFSM4INCLXPQ> .

datapythonista · 2019-09-12T16:53:26Z

Regarding size, I think it's around 500kb, but I still want to optimize the images in the Install page (the rest is almost nothing).

The 404 for the docs are expected. The plan is to merge this and then start integrating both, so there is no perception from the user that they are built separately. There are some challenges there, but spoke with Joris at EuroSciPy, and seems doable.

WillAyd · 2019-09-12T17:01:26Z

There is also an issue with sizing of content on the Contributors page due to long user names. Maybe OK to just have names and link to GH site if people wanted

We'll need to reconcile the styles by using a single CSS file for both, but that can be done afterwards I think.

Sounds good, though I'm wondering if we should commit to one style as part of this change then. Seems like it will be more hassle in the long run if the docs and rest of the site are built with two different style templates in mind and then we try merging later

jorisvandenbossche

In addition to the inline comments, the pandas_fibonnaci image can be removed I think?

jorisvandenbossche · 2019-09-17T13:11:16Z

web/pandas/_templates/layout.html

+<!DOCTYPE html>
+<html>
+    <head>
+        <title>pandas</title>


Suggested change

<title>pandas</title>

<title>pandas - Python Data Analysis Library</title>

jorisvandenbossche · 2019-09-17T13:13:07Z

web/pandas/_templates/layout.html

+              $('[data-toggle="popover"]').popover()
+            })
+            $(function () {
+                // temporary functionality to test different logos


Remove this before merging?

jorisvandenbossche · 2019-09-17T13:13:37Z

web/pandas/_templates/layout.html

+                crossorigin="anonymous"></script>
+        <script>
+            $(function () {
+              $('[data-toggle="tooltip"]').tooltip()


Can you add a comment for what those functions are needed?

jorisvandenbossche · 2019-09-17T13:15:17Z

web/pandas/_templates/layout.html

+                $(".navbar-brand img").attr("src", img);
+                $(".navbar-brand img").height(30);
+            });
+        </script>


To add to a todo list: add google analytics

jorisvandenbossche · 2019-09-17T13:20:46Z

web/pandas/community/citing.md

+            year={2011}
+        }
+
+## Brand and logo


Once we have a new logo, this probably deserves it's own apge

jorisvandenbossche · 2019-09-17T13:23:02Z

web/pandas/community/license.md

@@ -0,0 +1,31 @@
+# License
+


For me, this doesn't add much value as separate page on the website, I would say

jorisvandenbossche · 2019-09-17T13:40:46Z

I am trying it out locally, but the images are not working for me. Changing /static/... to static/.. in the paths (eg on the main page) seems to fix this, but not sure it is because I am doing something wrong.

Also the links in the navbar don't work locally.
Is this maybe because I am just opening the html files in the browser (as I am used to with sphinx), and I rather need to serve them on a localhost?

--

Can you add a README in the web/ directory shortly stating the purpose of that directory?

datapythonista · 2019-09-17T13:57:50Z

Addressed comments.

You need to run cd build && python -m http.server to navigate the website, links and image paths are absolute, not relative. If you want to build the website to live in a directory, you need the --base-url=/directory-for-the-web.

jorisvandenbossche · 2019-09-17T14:01:42Z

You need to run cd build && python -m http.server to navigate the website ...

Thanks! Can you add that note to the readme / command help?

jorisvandenbossche · 2019-09-17T14:05:52Z

web/pandas/_templates/layout.html

+                    <span class="navbar-toggler-icon"></span>
+                </button>
+
+                <a class="navbar-brand" href="{{ base_url }}/"><img alt="" src="{{ base_url }}{{ static.logo }}"/></a>


this is not working at the moment (I think static.logo is not defined right now?)

jorisvandenbossche · 2019-09-17T14:06:34Z

Another thing: the salsalabs donate container is not working (not locally, but also not on your hosted version)

…allation instructions

datapythonista · 2019-09-17T14:17:09Z

The iframe works for me, not sure if it was a temporary problem in their side, or you've got an adblocker or something preventing it to render.

datapythonista · 2019-09-17T14:18:27Z

I didn't want to include the logo, to avoid increasing the size of the repo with something will be replaced soon. I'm removing the logo from the html for now, so it doesn't show broken.

jorisvandenbossche · 2019-09-17T14:26:05Z

I didn't want to include the logo, to avoid increasing the size of the repo with something will be replaced soon. I'm removing the logo from the html for now, so it doesn't show broken.

Linking to the logo file in the docs does not work? (and I suppose on build copying that to the build directory)

datapythonista · 2019-09-17T14:29:50Z

That logo has the font in black, I could link it, but I'd have to change the header to white to look ok.

I think we still need several iterations with the website until we want to publish it to production, so I would focus on having a starting point so we can open PRs to it, and not in trying to have something final (it's far from it anyway, starting by the home page).

jorisvandenbossche · 2019-09-17T14:42:45Z

web/pandas/_templates/layout.html

+            (function() {
+                var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
+                ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
+                var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);


Can you use the same one as for the docs?

pandas/doc/source/themes/nature_with_gtoc/layout.html

Lines 98 to 106 in 372a9a0



<script>

window.ga=window.ga||function(){(ga.q=ga.q||[]).push(arguments)};ga.l=+new Date;

ga('create', 'UA-27880019-2', 'auto');

ga('set', 'anonymizeIp', true);

ga('send', 'pageview');

</script>

<script async src='https://www.google-analytics.com/analytics.js'></script>



(or is there a reason the above is better? then we can update the docs ones)

Also, can this go at the bottom scripts? Or is there a good reason to load this first?

I copied the one from the website, didn't know the docs had a different one.

I followed Google instructions on where to place it, they say immediately after the <head> tag.

I recently update the docs one, it was on my to do list to also update the website but didn't get to that yet ... (kind of proving your point here :-))

jorisvandenbossche · 2019-09-17T14:43:54Z

Yeah, no problem for the logo.

Sorry for more comments, but some final things on duplicated content: the new website also duplicates now the roadmap and the ecosystem pages from the docs. For those I would do the same as for the governance / contributing docs: leave that for separate PRs, as I don't think we should duplicate content here.
As you said, better to merge this quickly and iterate, so focusing on the infrastructure and not too much on those content details that might need some more discussion makes that easier.

datapythonista · 2019-09-17T14:49:11Z

I think there is agreement to move the roadmap and the ecosystem here, so I'll get rid of the versions in the docs if this is now ready to be merged.

jorisvandenbossche · 2019-09-17T14:54:55Z

I think there is agreement to move the roadmap and the ecosystem here,

Where has that been discussed? (I maybe missed some issues .. that's a problem with our huge number of issues)

datapythonista · 2019-09-17T15:01:45Z

There are few issues with discussions about the website, but the most important one was in this PR.

If I also remove these pages, this PR contains literally a home page that is incomplete, and not much more. So, I start to miss the point on whether this is a step forward, or we're just wasting time implementing something there is no minimum agreement on.

I'll leave this on hold until those decisions are made, working on this for weeks, and reverting everything again doesn't seem to be a great investment of my time, and it's quite frustrating.

jorisvandenbossche · 2019-09-17T15:56:28Z

Sorry, Marc, I didn't want to demean your efforts, and I understand your frustration as I have been very slow with feedback. Sorry for your that.

For me, there is still a clear added value of this PR: it is providing the base for working on a better home page (which is great work, as this is highly needed!). The exact items in the community dropdown are IMO not essential in the idea of a better website (although I have a strong opinion on it). It was in that light that I thought it would be easier to leave that for later. But I am also happy with merging this as is. It's just some text files that we can also further discuss after they are merged.

WillAyd · 2019-09-17T16:16:43Z

I’m also okay with merging as is and whittling down details later. I think this is a great improvement over current configuration

…

Sent from my iPhone

On Sep 17, 2019, at 8:56 AM, Joris Van den Bossche ***@***.***> wrote: Sorry, Marc, I didn't want to demean your efforts, and I understand your frustration as I have been very slow with feedback. Sorry for your frustration. For me, there is still a clear added value of this PR: it is providing the base for working on a better home page (which is great work, as this is highly needed). The exact items in the community dropdown are IMO not essential in the idea of a better website (although I have a strong opinion on it). It was in that light that I thought it would be easier to leave that for later. But I am also happy with merging this as is. It's just some text files that we can also further discuss after they are merged. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

TomAugspurger · 2019-09-17T16:34:59Z

Either order works for me as well. We'll be fixing things up anyway (since we're not yet removing the old roadmap.rst, right?) So merge this and let's iterate on it over the next few weeks? On Tue, Sep 17, 2019 at 11:16 AM William Ayd <notifications@github.com> wrote:

…

I’m also okay with merging as is and whittling down details later. I think this is a great improvement over current configuration Sent from my iPhone > On Sep 17, 2019, at 8:56 AM, Joris Van den Bossche < ***@***.***> wrote: > > Sorry, Marc, I didn't want to demean your efforts, and I understand your frustration as I have been very slow with feedback. Sorry for your frustration. > > For me, there is still a clear added value of this PR: it is providing the base for working on a better home page (which is great work, as this is highly needed). The exact items in the community dropdown are IMO not essential in the idea of a better website (although I have a strong opinion on it). It was in that light that I thought it would be easier to leave that for later. But I am also happy with merging this as is. It's just some text files that we can also further discuss after they are merged. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#28014?email_source=notifications&email_token=AAKAOISVRYRSTKSB3GWQNK3QKD7HHA5CNFSM4INCLXP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD65CJUA#issuecomment-532292816>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOISSYZM34PUCPB6EUDLQKD7HHANCNFSM4INCLXPQ> .

jorisvandenbossche · 2019-09-17T20:33:27Z

Yes, fine with merging as is and iterate.

To try to explain a bit more the potential reason for some of the disagreements we are having (what I also tried to say at EuroScipy regarding the doc theme / integration with the website):

I have been working on a new documentation theme, and for me, the main driver for that is because I find the navigation functionality of the current theme lacking.
But the current proposal of the website here (and the same for the current homepage) has even less navigation structure compared to the current doc theme. But to be clear, I think this is good for the main website. Because fancy overview landing pages like the home page or an about or donation page don't need much navigational structure. I see the main website mainly as this: attractive overview pages that give a good intro and overview and then further link to more detailed content (docs, github, mailing list, ...). But that also means that I personally prefer that all pages which are more heavily text-content based (like the contributing pages) stay in the documentation (sphinx) section, as there we are have the layout for handling such content.
Of course, nothing prevents us (technically) to use the same navigation structure (eg the sidebar(s)) also in the website pages. But I think this will give some duplicated content for the html layouts (the doc theme still is tailored towards sphinx), and to me it also seems a potential benefit to keep all the pages that uses this navigation in the same place (the sphinx content) while having the other content in the markdown (web) content. But for sure, this is only one option. We can also discuss and experiment with how to re-use some of the navigation structures from the doc theme also on the website.

datapythonista · 2019-09-17T21:54:04Z

Thanks for clarifying your point, I didn't understand the reasoning.

The division that I used was what needs to be served from master, and what from the latest release. I think it simplifies significantly how things are built and deployed.

In any case, I think we all agree we need to build the new website in iterations. I think after merging this (I'll do it tomorrow if there are no objections), and making a first integration with the docs, will be easier to see the advantages and disadvantages of every option.

@jorisvandenbossche do you think you can have a first version (possibly minimal) of the new docs layout merged soon? So we can experiment using the same templates in both the website and the docs (I think it shouldn't be difficult, and very useful).

TomAugspurger · 2019-09-18T13:38:56Z

Nice work Marc!

…

On Wed, Sep 18, 2019 at 8:25 AM Marc Garcia ***@***.***> wrote: Merged #28014 <#28014> into master. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#28014?email_source=notifications&email_token=AAKAOIVSDRIEOQFLK3RADBDQKIT35A5CNFSM4INCLXP2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTWIKTQI#event-2643503553>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIVMKHZE7IVPHBH2HO3QKIT35ANCNFSM4INCLXPQ> .

Adding new pandas website

192df97

datapythonista added the Web pandas website label Aug 19, 2019

Fixing CI

14a606f

Marc Garcia added 2 commits August 20, 2019 10:20

Adding Tidelift to partners

b682dfe

Fixing Wes book link and changing image to the 2nd edition

541d26d

datapythonista mentioned this pull request Aug 20, 2019

New citing and artwork section in the pandas website python-sprints/pandas-mentoring#119

Closed

wesm reviewed Aug 20, 2019

View reviewed changes

Updated link to Wes book with Amazon affiliate link

b6de1d4

datapythonista changed the title ~~Adding new pandas website~~ WEB: Adding new pandas website Aug 27, 2019

datapythonista mentioned this pull request Aug 27, 2019

WEB: Home page content for the new website #28168

Open

11 tasks

Marc Garcia added 2 commits August 29, 2019 14:32

Removing carousel and self-hosted juniper.js, replaced Ursa Labs logo…

507eb7e

… by its svg format

Merge remote-tracking branch 'upstream/master' into pandas_web

711fc8c

Marc Garcia added 6 commits September 10, 2019 16:22

Merge remote-tracking branch 'upstream/master' into pandas_web

617cfb9

Updating feeds with pandas only posts (Wes and Marc)

aa54548

Merge remote-tracking branch 'upstream/master' into pandas_web

8ae611d

Renaming the pandas builder, since for now doesn't seem like any othe…

e322c03

…r project is interested in contributing it upstream

Making the website responsive (adding viewport meta)

6063061

Improving styles, and temporary removing the blog and the try/binder …

d163d73

…page

TomAugspurger reviewed Sep 12, 2019

View reviewed changes

Marc Garcia added 2 commits September 17, 2019 14:21

Removing contributing documentation

aca4f52

Merging from master

fe8c211

jorisvandenbossche reviewed Sep 17, 2019

View reviewed changes

Addressing review comments

916544f

jorisvandenbossche reviewed Sep 17, 2019

View reviewed changes

Adding note about serving the website using an http server

532a2f7

Hidding logo if not present, and removing last screenshot of the inst…

d7436fe

…allation instructions

jorisvandenbossche reviewed Sep 17, 2019

View reviewed changes

datapythonista merged commit ae71459 into pandas-dev:master Sep 18, 2019

jorisvandenbossche mentioned this pull request Sep 23, 2019

WEB/DOC: integration of the main website and documentation #28580

Open

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

WEB: Adding new pandas website (pandas-dev#28014)

bb899a9

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

WEB: Adding new pandas website (pandas-dev#28014)

bd4df41

	<title>pandas</title>
	<title>pandas - Python Data Analysis Library</title>

	<!-- Google Analytics -->
	<script>
	window.ga=window.ga\|\|function(){(ga.q=ga.q\|\|[]).push(arguments)};ga.l=+new Date;
	ga('create', 'UA-27880019-2', 'auto');
	ga('set', 'anonymizeIp', true);
	ga('send', 'pageview');
	</script>
	<script async src='https://www.google-analytics.com/analytics.js'></script>
	<!-- End Google Analytics -->

WEB: Adding new pandas website #28014

WEB: Adding new pandas website #28014

Conversation

datapythonista commented Aug 19, 2019 • edited Loading

topper-123 commented Aug 19, 2019

datapythonista commented Aug 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mroeschke commented Aug 20, 2019

datapythonista commented Aug 20, 2019

datapythonista commented Aug 29, 2019

datapythonista commented Sep 12, 2019

TomAugspurger commented Sep 12, 2019

WillAyd commented Sep 12, 2019 via email

TomAugspurger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomAugspurger commented Sep 12, 2019 via email

datapythonista commented Sep 12, 2019

WillAyd commented Sep 12, 2019

jorisvandenbossche left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorisvandenbossche commented Sep 17, 2019

datapythonista commented Sep 17, 2019

jorisvandenbossche commented Sep 17, 2019

Choose a reason for hiding this comment

jorisvandenbossche commented Sep 17, 2019

datapythonista commented Sep 17, 2019

datapythonista commented Sep 17, 2019

jorisvandenbossche commented Sep 17, 2019

datapythonista commented Sep 17, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorisvandenbossche commented Sep 17, 2019

datapythonista commented Sep 17, 2019

jorisvandenbossche commented Sep 17, 2019

datapythonista commented Sep 17, 2019

jorisvandenbossche commented Sep 17, 2019 • edited Loading

WillAyd commented Sep 17, 2019 via email

TomAugspurger commented Sep 17, 2019 via email

jorisvandenbossche commented Sep 17, 2019

datapythonista commented Sep 17, 2019

TomAugspurger commented Sep 18, 2019 via email

datapythonista commented Aug 19, 2019 •

edited

Loading

jorisvandenbossche commented Sep 17, 2019 •

edited

Loading