-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TYPING: add stubs for _packer and _unpacker #28135
Conversation
Are there packaging considerations to be made here? Given these modules are deprecated I think we should just ignore them if causing problems |
we will still be accepting bugfixes? if so, type hints should be a benefit. no reason to ignore? |
we haven’t really quite decided on the length of this deprecation |
Sounds good. Would we need to do anything with setup.py to get these distributed? |
atm we're primarily concerned with code quality? (and reducing the pull request review overhead if mypy can find problems) making pandas PEP 561 compatible is outside the scope of the PR. https://mypy.readthedocs.io/en/latest/installed_packages.html#making-pep-561-compatible-packages |
Cool that's what I was asking about. Yea doesn't need to be solved here but seems like already some people have started using types hints with IDEs, so would be good to ship stubs alongside releases. If you want to open an issue for that discussion would be helpful |
personally, my time spent in an IDE is with pandas itself and use notebook for using pandas. so i'll raise the issue but add contributions welcome so that someone using pandas as a library in an IDE can perhaps take it on. |
Thanks @simonjayhawkins |
xref #28133