Skip to content

TST: suppress 1485 warnings issued by xml parser #28514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

jbrockmendel
Copy link
Member

So we don't have to scroll through tons of

pandas/tests/io/excel/test_xlrd.py::test_excel_table_sheet_by_index[.xlsm]
  /usr/local/lib/python3.7/site-packages/xlrd/xlsx.py:312: PendingDeprecationWarning: This method will be removed in future versions.  Use 'tree.iter()' or 'list(tree.iter())' instead.
    for elem in self.tree.iter() if Element_has_iter else self.tree.getiterator():

@WillAyd
Copy link
Member

WillAyd commented Sep 19, 2019

related to #27016

@TomAugspurger TomAugspurger merged commit 9c7e604 into pandas-dev:master Sep 19, 2019
@TomAugspurger
Copy link
Contributor

Thanks!

@TomAugspurger TomAugspurger added this to the 1.0 milestone Sep 19, 2019
@TomAugspurger
Copy link
Contributor

Do we know when that will be enforced? 3.9? So xlrd will be totally broken by then?

@WillAyd
Copy link
Member

WillAyd commented Sep 19, 2019

I'm not sure. It's the getiterator function in xml.etree.ElementTree which was deprecated back in 3.2. It's at least still available in 3.8

Also I can't guarantee it will break xlrd when removed as xlrd relies on a few different underlying parsers and may fall back in case of failure. In any case it's not something that will be changed since that package isn't maintained any more

@jbrockmendel jbrockmendel deleted the blue branch September 19, 2019 16:05
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants