Skip to content

Update contributing.rst #28713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update contributing.rst #28713

wants to merge 1 commit into from

Conversation

mimikaan
Copy link

@mimikaan mimikaan commented Oct 1, 2019

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Oct 1, 2019

this is duplicating #28705

jbrockmendel
jbrockmendel reviewed Oct 18, 2019
View reviewed changes
@jbrockmendel
Copy link
Member

@mimikaan can you address comments

mimikaan
mimikaan commented Nov 2, 2019
View reviewed changes
Copy link
Author

@mimikaan mimikaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alterations were correct

@mimikaan mimikaan closed this Nov 2, 2019
@mimikaan mimikaan reopened this Nov 2, 2019
@jreback
Copy link
Contributor

jreback commented Nov 2, 2019

was already covered by #28907

thanks

@jreback jreback closed this Nov 2, 2019
@jreback jreback added the Docs label Nov 2, 2019
@jreback jreback added this to the No action milestone Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mimikaan @jreback @jbrockmendel