CLN: Consistent pandas.util.testing imports in remaining test suite #29307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaturnFromTitan
changed the title
simonjayhawkins
added
Clean
Testing
|
thanks @SaturnFromTitan when the last of the imports are done, can you prepare a change to fail the CI on incorrect imports. this go in the ci/code_checks.sh script, see how we exclude numpy.testing (but maybe need to be a bit more sophistacted here). |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29272
Fyi: All changes are generated from a script posted in the issue.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffFyi: When the remaining PRs of this are merged, I'll add another one to add the linting rule - then we can close the issue