Skip to content

add unit tests for issue #19351 #29438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2019
Merged

add unit tests for issue #19351 #29438

merged 3 commits into from
Nov 6, 2019

Conversation

acarl005
Copy link
Contributor

@acarl005 acarl005 commented Nov 6, 2019

This is a unit test for an already fixed problem.

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite labels Nov 6, 2019
@jreback jreback added this to the 1.0 milestone Nov 6, 2019
@@ -358,6 +358,53 @@ def test_unstack(self):
# test that int32 work
self.ymd.astype(np.int32).unstack()

def test_unstack_partial(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally would like to parametrize this, have a look at pandas/tests/reshape/merge/test_merge.py for examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. done!

@jreback jreback merged commit b72f928 into pandas-dev:master Nov 6, 2019
@jreback
Copy link
Contributor

jreback commented Nov 6, 2019

thanks @acarl005 !

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstack throws when run on subset of DataFrame
2 participants